You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/31 15:21:54 UTC
[GitHub] [pulsar] congbobo184 opened a new pull request #9383: [Java Client] Fix issue 9344
congbobo184 opened a new pull request #9383:
URL: https://github.com/apache/pulsar/pull/9383
## Motivation
link issue : https://github.com/apache/pulsar/pull/9322
### Verifying this change
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a change in pull request #9383: [Java Client] Batch version of acknowledgeAsync will return a completed future before individual messages complete
Posted by GitBox <gi...@apache.org>.
eolivelli commented on a change in pull request #9383:
URL: https://github.com/apache/pulsar/pull/9383#discussion_r567710042
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -369,8 +372,11 @@ public void reconsumeLaterCumulative(Message<?> message, long delayTime, TimeUni
@Override
public CompletableFuture<Void> acknowledgeAsync(Messages<?> messages) {
try {
- messages.forEach(this::acknowledgeAsync);
- return CompletableFuture.completedFuture(null);
+ List<MessageId> messageIds = new ArrayList<>();
+ messages.forEach(message -> messageIds.add(message.getMessageId()));
+ CompletableFuture<Void> completableFuture = acknowledgeAsync(messageIds);
Review comment:
nit: you can save declaring this variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #9383: [Java Client] Fix issue 9344
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on pull request #9383:
URL: https://github.com/apache/pulsar/pull/9383#issuecomment-770482916
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai merged pull request #9383: [Java Client] Batch version of acknowledgeAsync will return a completed future before individual messages complete
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #9383:
URL: https://github.com/apache/pulsar/pull/9383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org