You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Sssan520 <gi...@git.apache.org> on 2018/07/25 11:30:20 UTC

[GitHub] carbondata pull request #2557: [CARBONDATA-2782]delete dead code in class 'C...

GitHub user Sssan520 opened a pull request:

    https://github.com/apache/carbondata/pull/2557

    [CARBONDATA-2782]delete dead code  in class 'CarbonCleanFilesCommand'

    the variables(dms、indexDms) in function processMetadata are nerver used.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed? No
     
     - [ ] Any backward compatibility impacted? No
     
     - [ ] Document update required? No
    
     - [ ] Testing done NA
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Sssan520/carbondata issue2782

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2557
    
----
commit 83838651e9b7513963f27da49f13564d7f117a28
Author: Sssan520 <li...@...>
Date:   2018-07-25T11:14:18Z

    [CARBONDATA-2782]delete dead code

----


---

[GitHub] carbondata issue #2557: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2557
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7500/



---

[GitHub] carbondata issue #2557: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2557
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6255/



---

[GitHub] carbondata issue #2557: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

Posted by Sssan520 <gi...@git.apache.org>.
Github user Sssan520 commented on the issue:

    https://github.com/apache/carbondata/pull/2557
  
    retest this please


---

[GitHub] carbondata issue #2557: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

Posted by Sssan520 <gi...@git.apache.org>.
Github user Sssan520 commented on the issue:

    https://github.com/apache/carbondata/pull/2557
  
    retest this please


---

[GitHub] carbondata pull request #2557: [CARBONDATA-2782]delete dead code in class 'C...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2557


---

[GitHub] carbondata issue #2557: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/2557
  
    please check your git config


---

[GitHub] carbondata issue #2557: [CARBONDATA-2782]delete dead code in class 'CarbonCl...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2557
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7506/



---