You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "HTHou (via GitHub)" <gi...@apache.org> on 2024/10/23 03:44:51 UTC
[PR] Keep all null rows in table model flush [iotdb]
HTHou opened a new pull request, #13883:
URL: https://github.com/apache/iotdb/pull/13883
## Description
As title. Refer https://github.com/apache/iotdb/pull/13487.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep all null rows in table model flush [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13883:
URL: https://github.com/apache/iotdb/pull/13883#issuecomment-2430817812
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13883) **Quality Gate failed**
Failed conditions
 [36.1% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=13883&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13883) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=13883)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep all null rows in table model flush [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13883:
URL: https://github.com/apache/iotdb/pull/13883#issuecomment-2430882144
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13883?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 39.84%. Comparing base [(`576b6d5`)](https://app.codecov.io/gh/apache/iotdb/commit/576b6d57e05a03842101ec9cc941256018fb7bfb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`efea121`)](https://app.codecov.io/gh/apache/iotdb/commit/efea1216294622f57716b8c79729923616fbbcae?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #13883 +/- ##
=========================================
Coverage 39.83% 39.84%
Complexity 71 71
=========================================
Files 4153 4153
Lines 262907 262957 +50
Branches 32014 32020 +6
=========================================
+ Hits 104727 104767 +40
- Misses 158180 158190 +10
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/13883?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Keep all null rows in table model flush [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #13883:
URL: https://github.com/apache/iotdb/pull/13883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org