You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/09/19 20:12:00 UTC
[jira] [Commented] (ZOOKEEPER-3032) Step 1.6 - Create zk-server
maven structure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621135#comment-16621135 ]
Hadoop QA commented on ZOOKEEPER-3032:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 890 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to cause Findbugs (version 3.0.1) to fail.
-1 release audit. The applied patch generated 3 release audit warnings (more than the trunk's current 0 warnings).
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2207//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2207//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2207//console
This message is automatically generated.
> Step 1.6 - Create zk-server maven structure
> -------------------------------------------
>
> Key: ZOOKEEPER-3032
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3032
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: build, scripts
> Affects Versions: 3.6.0
> Reporter: Norbert Kalmar
> Assignee: Norbert Kalmar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Create a project structure that separates the different parts of ZooKeeper into a more meaningful packages for the future maven build.
> This should be done in iterations to limit the impact.
> * First iteration - safe changes including moving src/docs to zk-docs, creating zk-it empty directory. Build and conf directory remains unchanged. These changes also have minimum impact on PR’s.
> * Second iteration - move src/recipes to zk-recipes.
> * Third iteration - move src/contrib to zk-contrib.
> * Fourth iteration - move src/c to zk-client (java will be moved in Phase 2)
> * Fifth iteration - move jute under src directory
> * *Sixth iteration* - move src/java/main to zk-server, also separate client code from server code, move common files to zookeeper-common.
> {noformat}
> zookeeper
> | -bin
> | -conf
> | -jute
> | -zookeeper-client
> | | -zookeeper-client-c
> | | -zookeeper-client-java
> | -zookeeper-common
> | -zookeeper-contrib
> | | -zookeeper-contrib-fatjar
> | | -zookeeper-contrib-huebrowser
> | | -zookeeper-contrib-loggraph
> | | -zookeeper-contrib-monitoring
> | | -zookeeper-contrib-rest
> | | -zookeeper-contrib-zkfuse
> | | -zookeeper-contrib-zkperl
> | | -zookeeper-contrib-zkpython
> | | -zookeeper-contrib-zktreeutil
> | \ -zookeeper-contrib-zooinspector
> | -zookeeper-docs
> | -zookeeper-it (integration tests)
> | -zookeeper-server
> | -zookeeper-recipes
> | | -zookeeper-recipes-election
> | | -zookeeper-recipes-lock
> \ \ -zookeeper-recipes-queue
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)