You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/30 23:47:34 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #5182: [MINOR] Fixing parquet reader iterator close
nsivabalan opened a new pull request #5182:
URL: https://github.com/apache/hudi/pull/5182
## What is the purpose of the pull request
After saw a comment on https://github.com/apache/hudi/commit/f2a93ead3b5a6964a72b3543ada58aa334edef9c#r69671705 regarding the closable and autoClosable, I went back to check the code. We use https://github.com/apache/spark/blob/ef8fb9b9d84b6adfe5a4e03b6e775e709d624144/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala#L200 which returns an iterator and not an instance of Closable or AutoClosable. But guarding it using AutoClosable.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5182: [MINOR] Fixing parquet reader iterator close
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5182:
URL: https://github.com/apache/hudi/pull/5182#issuecomment-1083799817
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7592",
"triggerID" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67d0c2b5abb88b41089780d6b9014b7c8aa40c03 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7592)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5182: [MINOR] Fixing parquet reader iterator close
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5182:
URL: https://github.com/apache/hudi/pull/5182#issuecomment-1083799817
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7592",
"triggerID" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67d0c2b5abb88b41089780d6b9014b7c8aa40c03 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7592)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #5182: [MINOR] Fixing parquet reader iterator close
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #5182:
URL: https://github.com/apache/hudi/pull/5182#issuecomment-1083795295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67d0c2b5abb88b41089780d6b9014b7c8aa40c03 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5182: [MINOR] Fixing parquet reader iterator close
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5182:
URL: https://github.com/apache/hudi/pull/5182#issuecomment-1084051167
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7592",
"triggerID" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67d0c2b5abb88b41089780d6b9014b7c8aa40c03 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7592)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5182: [MINOR] Fixing parquet reader iterator close
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #5182:
URL: https://github.com/apache/hudi/pull/5182#issuecomment-1083795295
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "67d0c2b5abb88b41089780d6b9014b7c8aa40c03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 67d0c2b5abb88b41089780d6b9014b7c8aa40c03 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org