You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2019/12/12 18:16:27 UTC
[GitHub] [cassandra] dcapwell commented on a change in pull request #396:
CASSANDRA-15447 - Pass correct seed node through to InstanceConfig so it
can set it properly when starting clusters on non-0 subnets.
dcapwell commented on a change in pull request #396: CASSANDRA-15447 - Pass correct seed node through to InstanceConfig so it can set it properly when starting clusters on non-0 subnets.
URL: https://github.com/apache/cassandra/pull/396#discussion_r357295911
##########
File path: test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java
##########
@@ -239,20 +240,22 @@ public String getString(String name)
return (String)params.get(name);
}
- public static InstanceConfig generate(int nodeNum, String ipAddress, NetworkTopology networkTopology, File root, String token)
+ public static InstanceConfig generate(int nodeNum, String ipAddress, NetworkTopology networkTopology, File root, String token, String seedIp)
{
return new InstanceConfig(nodeNum,
networkTopology,
ipAddress,
ipAddress,
ipAddress,
ipAddress,
+ seedIp,
String.format("%s/node%d/saved_caches", root, nodeNum),
new String[] { String.format("%s/node%d/data", root, nodeNum) },
String.format("%s/node%d/commitlog", root, nodeNum),
String.format("%s/node%d/hints", root, nodeNum),
String.format("%s/node%d/cdc", root, nodeNum),
- token);
+ token
Review comment:
nit: moving it back would shrink the diff (up to you)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org