You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/27 13:40:45 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1491: feat(config): add root config api builder
LaurenceLiZhixin commented on a change in pull request #1491:
URL: https://github.com/apache/dubbo-go/pull/1491#discussion_r716702440
##########
File path: config/dubbo_bootstrap.go
##########
@@ -71,16 +72,27 @@ func (rc *RootConfig) Init() error {
if err := rc.Application.Init(); err != nil {
return err
}
- if err := initProtocolsConfig(rc); err != nil {
- return err
+
+ // init protocol
+ protocols := rc.Protocols
Review comment:
这个地方感觉没必要加默认协议吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org