License headers in cloud-core

[Hugo Trippaers <hu...@apache.org>]

Heya,

Just a headsup, but i pushed a rather big looking change into core. It doesn’t actually make any changes, except for formatting on the license headers. We used to have some standards on the formatting of the license headers, but they were not really looked after (unless rat complains of course). However i’ve been introducing the maven-license-plugin in several modules now and that one is a little more strict about the formatting.

So the obvious downside is that your compile of cloud-core will break if you forget the license or use a wrong format. 

The upside is that the command mvn -pl :cloud-core com.mycila:license-maven-plugin:format will automagically fix it for you.

Cheers,

Hugo

P.S. For those wondering why i don’t just put the format command in the pom file instead of the check; we need to ensure that the author is aware that the license is added.
 

Re: License headers in cloud-core

[Daan Hoogland <da...@gmail.com>]

.../gi ???

On Mon, Jul 14, 2014 at 6:52 PM, Chip Childers <ch...@apache.org> wrote:
> On Mon, Jul 14, 2014 at 04:52:24PM +0200, Hugo Trippaers wrote:
>> The upside is that the command mvn -pl :cloud-core com.mycila:license-maven-plugin:format will automagically fix it for you.
>
> s/upside/downside



-- 
Daan

Re: License headers in cloud-core

[Chip Childers <ch...@apache.org>]

On Mon, Jul 14, 2014 at 04:52:24PM +0200, Hugo Trippaers wrote:
> The upside is that the command mvn -pl :cloud-core com.mycila:license-maven-plugin:format will automagically fix it for you.

s/upside/downside