[GitHub] [druid] jihoonson commented on a change in pull request #9375: Add support for optional aws credentials for s3 for ingestion

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #9375: Add support for optional aws credentials for s3 for ingestion
URL: https://github.com/apache/druid/pull/9375#discussion_r384026183
 
 

 ##########
 File path: extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3StorageDruidModule.java
 ##########
 @@ -166,9 +166,11 @@ public void configure(Binder binder)
     binder.bind(S3TaskLogs.class).in(LazySingleton.class);
   }
 
+  // This provides ServerSideEncryptingAmazonS3.Builder with default configs from Guice injection initially set.
+  // However, this builder can then be modify and have configuration(s) inside
 
 Review comment:
   modify -> modified?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org