You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey A. Ivanov (JIRA)" <ji...@apache.org> on 2006/11/15 09:35:37 UTC
[jira] Created: (HARMONY-2189) [classlib][swing]
j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
[classlib][swing] j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
---------------------------------------------------------------------------------------
Key: HARMONY-2189
URL: http://issues.apache.org/jira/browse/HARMONY-2189
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Alexey A. Ivanov
javax.swing.text.CompositeView.getInsideAllocation() returns the inside allocation, i.e. removes inset area from an allocation given. Since any of get{Top, Left, Bottom, Right}Inset() methods can be overridden, getInsideAllocation() should call them to fetch the insets rather than directly using fields where inserts are stored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2189) [classlib][swing]
j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2189?page=all ]
Alexey A. Ivanov updated HARMONY-2189:
--------------------------------------
Attachment: H2189-CompositeView.patch
Fixes the issue.
Also adds @Override to all overridden methods.
> [classlib][swing] j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
> ---------------------------------------------------------------------------------------
>
> Key: HARMONY-2189
> URL: http://issues.apache.org/jira/browse/HARMONY-2189
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Attachments: H2189-CompositeView.patch, H2189-CompositeViewTest.patch
>
>
> javax.swing.text.CompositeView.getInsideAllocation() returns the inside allocation, i.e. removes inset area from an allocation given. Since any of get{Top, Left, Bottom, Right}Inset() methods can be overridden, getInsideAllocation() should call them to fetch the insets rather than directly using fields where inserts are stored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2189) [classlib][swing]
j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2189?page=all ]
Alexey A. Ivanov updated HARMONY-2189:
--------------------------------------
Attachment: H2189-CompositeViewTest.patch
Regression test for this issue.
Also adds @Override to all overridden methods.
> [classlib][swing] j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
> ---------------------------------------------------------------------------------------
>
> Key: HARMONY-2189
> URL: http://issues.apache.org/jira/browse/HARMONY-2189
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Attachments: H2189-CompositeView.patch, H2189-CompositeViewTest.patch
>
>
> javax.swing.text.CompositeView.getInsideAllocation() returns the inside allocation, i.e. removes inset area from an allocation given. Since any of get{Top, Left, Bottom, Right}Inset() methods can be overridden, getInsideAllocation() should call them to fetch the insets rather than directly using fields where inserts are stored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2189) [classlib][swing]
j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2189?page=all ]
Alexey A. Ivanov updated HARMONY-2189:
--------------------------------------
Estimated Complexity: Novice (was: Moderate)
> [classlib][swing] j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
> ---------------------------------------------------------------------------------------
>
> Key: HARMONY-2189
> URL: http://issues.apache.org/jira/browse/HARMONY-2189
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
>
> javax.swing.text.CompositeView.getInsideAllocation() returns the inside allocation, i.e. removes inset area from an allocation given. Since any of get{Top, Left, Bottom, Right}Inset() methods can be overridden, getInsideAllocation() should call them to fetch the insets rather than directly using fields where inserts are stored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2189) [classlib][swing]
j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2189?page=all ]
Alexey A. Ivanov updated HARMONY-2189:
--------------------------------------
Patch Info: [Patch Available]
> [classlib][swing] j.s.text.CompositeView.getInsideAllocation doesn't call inset getters
> ---------------------------------------------------------------------------------------
>
> Key: HARMONY-2189
> URL: http://issues.apache.org/jira/browse/HARMONY-2189
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Attachments: H2189-CompositeView.patch, H2189-CompositeViewTest.patch
>
>
> javax.swing.text.CompositeView.getInsideAllocation() returns the inside allocation, i.e. removes inset area from an allocation given. Since any of get{Top, Left, Bottom, Right}Inset() methods can be overridden, getInsideAllocation() should call them to fetch the insets rather than directly using fields where inserts are stored.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira