You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/21 03:36:47 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #34337: [SPARK-37066][SQL] Improve error message to show file path when read next file

AngersZhuuuu commented on a change in pull request #34337:
URL: https://github.com/apache/spark/pull/34337#discussion_r733295004



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
##########
@@ -177,6 +177,10 @@ class FileScanRDD(
                 throw QueryExecutionErrors.cannotReadParquetFilesError(e)
               }
               throw e
+            case e: ArrayIndexOutOfBoundsException =>
+              logError(s"Throw ArrayIndexOutOfBoundsException: ${e.getMessage} " +
+                s"while reading file ${currentFile.filePath}")
+              throw e

Review comment:
       > Do you mean `case e: Exception` instead of `case e: ArrayIndexOutOfBoundsException`? It sounds like a broader scope of your PR title and goal.
   > 
   > You may revise this PR (title and PR description) for that if you want to do that for both Parquet/ORC and others.
   
   Update the pr desc and how about current?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org