[GitHub] [incubator-superset] xtinec commented on a change in pull request #8085: Add LogConfigurator, and add logging for CSV export

[GitBox <gi...@apache.org>]

xtinec commented on a change in pull request #8085: Add LogConfigurator, and add logging for CSV export
URL: https://github.com/apache/incubator-superset/pull/8085#discussion_r318266618
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2685,7 +2685,17 @@ def csv(self, client_id):
         response.headers[
             "Content-Disposition"
         ] = f"attachment; filename={query.name}.csv"
-        logging.info("Ready to return response")
+        event_info = {
 
 Review comment:
   Do we care to log the user who performed the csv export for auditing purposes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org