You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/06 02:07:43 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

AngersZhuuuu opened a new pull request #33661:
URL: https://github.com/apache/spark/pull/33661


   ### What changes were proposed in this pull request?
   Support comparison of ANSI intervals with different fields
   
   
   ### Why are the changes needed?
   Support comparison of ANSI intervals with different fields
   
   
   ### Does this PR introduce _any_ user-facing change?
   user can use comparison function with  different fields of DayTimeIntervalType/YearMonthIntervalType
   
   
   ### How was this patch tested?
   Added UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894077637


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46653/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684181013



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,8 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1' YEAR = INTERVAL '1' MONTH;
+SELECT INTERVAL '1-1' YEAR TO MONTH = INTERVAL '13' MONTH;
+SELECT INTERVAL '13' MONTH > INTERVAL '1' YEAR;

Review comment:
       Update a lot test, should be enough




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893951128


   **[Test build #142122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142122/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895135839


   **[Test build #142224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142224/testReport)** for PR 33661 at commit [`ee80531`](https://github.com/apache/spark/commit/ee80531448dbf6075daa2191d87be86a5b91eebe).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894355920


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46669/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895786453


   **[Test build #142260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142260/testReport)** for PR 33661 at commit [`22c1eea`](https://github.com/apache/spark/commit/22c1eea661a1d089e7d9676168b3042cf468c0c9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894000248


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142122/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894355920


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46669/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894818293


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142198/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895713024


   **[Test build #142254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142254/testReport)** for PR 33661 at commit [`19f5661`](https://github.com/apache/spark/commit/19f5661fd43692afb08b1764a683e74612d412bf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685743882



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,15 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1 02' DAY TO HOUR = INTERVAL '02:10:55' HOUR TO SECOND;
+SELECT INTERVAL '1' YEAR < INTERVAL '1' MONTH;
+SELECT INTERVAL '-1-1' YEAR TO MONTH = INTERVAL '-13' MONTH;
+SELECT INTERVAL 1 MONTH > INTERVAL 20 DAYS;
+
+SELECT array(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
+SELECT array(INTERVAL '1' DAY, INTERVAL '01:01' HOUR TO MINUTE);
+SELECT coalesce(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
+SELECT coalesce(INTERVAL '1' DAY, INTERVAL '01:01' HOUR TO MINUTE);
+SELECT coalesce(INTERVAL 1 MONTH, INTERVAL 20 DAYS);

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895475956






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685341398



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -867,6 +869,9 @@ object TypeCoercion extends TypeCoercionBase {
       case (_: TimestampType, _: DateType) | (_: DateType, _: TimestampType) =>
         Some(TimestampType)
 
+      case (_: DayTimeIntervalType, _: DayTimeIntervalType) => Some(DayTimeIntervalType())
+      case (_: YearMonthIntervalType, _: YearMonthIntervalType) => Some(YearMonthIntervalType())

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894148867


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895140477


   **[Test build #142224 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142224/testReport)** for PR 33661 at commit [`ee80531`](https://github.com/apache/spark/commit/ee80531448dbf6075daa2191d87be86a5b91eebe).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685000011



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/IntervalExpressionsSuite.scala
##########
@@ -661,4 +661,17 @@ class IntervalExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
         }
     }
   }
+
+  test("SPARK-36431: Support comparison of ANSI intervals with different fields") {

Review comment:
       The UT here should not test type coercion. Let's remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685091464



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/IntervalExpressionsSuite.scala
##########
@@ -661,4 +661,17 @@ class IntervalExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
         }
     }
   }
+
+  test("SPARK-36431: Support comparison of ANSI intervals with different fields") {

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895188139


   Kubernetes integration test unable to build dist.
   
   exiting with code: 141
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46736/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684998668



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala
##########
@@ -120,6 +120,9 @@ object AnsiTypeCoercion extends TypeCoercionBase {
     case (_: TimestampType, _: DateType) | (_: DateType, _: TimestampType) =>
       Some(TimestampType)
 
+    case (_: DayTimeIntervalType, _: DayTimeIntervalType) => Some(DayTimeIntervalType())

Review comment:
       shall we pick the smaller start field and larger end field as the result fields?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685714228



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,13 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1 02' DAY TO HOUR = INTERVAL '02:10:55' HOUR TO SECOND;
+SELECT INTERVAL '1' YEAR < INTERVAL '1' MONTH;
+SELECT INTERVAL '-1-1' YEAR TO MONTH = INTERVAL '-13' MONTH;

Review comment:
       Done

##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,13 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1 02' DAY TO HOUR = INTERVAL '02:10:55' HOUR TO SECOND;
+SELECT INTERVAL '1' YEAR < INTERVAL '1' MONTH;
+SELECT INTERVAL '-1-1' YEAR TO MONTH = INTERVAL '-13' MONTH;
+
+SELECT array(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
+SELECT array(INTERVAL '1' DAY, '01:01' HOUR TO MINUTE);
+SELECT coalesce(INTERVAL '1' YEAR, INTERVAL '1' MONTH);

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894806256


   **[Test build #142198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142198/testReport)** for PR 33661 at commit [`38c6857`](https://github.com/apache/spark/commit/38c6857a3d58b18be272459026980e7de5682c79).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894821450


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46710/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685001332



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,28 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;

Review comment:
       and test `array(...)`, `coalesce(...)` as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895787758


   **[Test build #142250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142250/testReport)** for PR 33661 at commit [`74ccdad`](https://github.com/apache/spark/commit/74ccdad6441a0477980a08ac1579712764bc240d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895715108


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142254/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685347771



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala
##########
@@ -120,6 +121,15 @@ object AnsiTypeCoercion extends TypeCoercionBase {
     case (_: TimestampType, _: DateType) | (_: DateType, _: TimestampType) =>
       Some(TimestampType)
 
+    case (t1: DayTimeIntervalType, t2: DayTimeIntervalType) =>
+      Some(DayTimeIntervalType(
+        IntervalUtils.minAnsiIntervalField(t1.startField, t2.startField),

Review comment:
       > just `t1.startField.min(t2.startField)`?
   
   There is such a convenient API。。。Updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685371712



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,47 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;

Review comment:
       I'd only keep
   ```
   SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
   SELECT INTERVAL '1 02' DAY TO HOUR = INTERVAL '02:10:55' HOUR TO SECOND;
   SELECT INTERVAL '1' YEAR < INTERVAL '1' MONTH;
   SELECT INTERVAL '-1-1' YEAR TO MONTH = INTERVAL '-13' MONTH;
   
   SELECT array(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
   SELECT array(INTERVAL '1' DAY, '01:01' HOUR TO MINUTE);
   SELECT coalesce(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
   SELECT coalesce(INTERVAL '1' DAY, '01:01' HOUR TO MINUTE); 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894213542


   @AngersZhuuuu The GA failure was resolved in #33660. Could you rebase to `master`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895351204






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895839758


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46767/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895390979


   **[Test build #142234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142234/testReport)** for PR 33661 at commit [`667f1da`](https://github.com/apache/spark/commit/667f1da9cbd02e54488ddb20ecc4061d730d521f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895713024


   **[Test build #142254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142254/testReport)** for PR 33661 at commit [`19f5661`](https://github.com/apache/spark/commit/19f5661fd43692afb08b1764a683e74612d412bf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894343730


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46669/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894056958


   **[Test build #142141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142141/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893976568


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46633/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894806256


   **[Test build #142198 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142198/testReport)** for PR 33661 at commit [`38c6857`](https://github.com/apache/spark/commit/38c6857a3d58b18be272459026980e7de5682c79).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895802623


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46764/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895938345


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142257/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895167437






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895789269


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142250/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895487164


   **[Test build #142233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142233/testReport)** for PR 33661 at commit [`582bdb2`](https://github.com/apache/spark/commit/582bdb2e69926431863c6a9bfa4db3394488da20).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895839793


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46767/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893949119


   ping @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894215875


   > @AngersZhuuuu The GA failure was resolved in #33660. Could you rebase to `master`?
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684278722



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -840,10 +840,17 @@ abstract class BinaryComparison extends BinaryOperator with Predicate {
 
   final override val nodePatterns: Seq[TreePattern] = Seq(BINARY_COMPARISON)
 
-  override def checkInputDataTypes(): TypeCheckResult = super.checkInputDataTypes() match {
-    case TypeCheckResult.TypeCheckSuccess =>
-      TypeUtils.checkForOrderingExpr(left.dataType, this.getClass.getSimpleName)
-    case failure => failure
+  override def checkInputDataTypes(): TypeCheckResult = {
+    val matched = (left.dataType, right.dataType) match {
+      case (l: DayTimeIntervalType, r: DayTimeIntervalType) => TypeCheckResult.TypeCheckSuccess

Review comment:
       It's a bit weird that we allow different types in binary comparison. Can we fix the type coercion instead? e.g. `TypeCoercion.findTightestCommonType`. This is also more general, we can also support `coalesce(interval1, interval2)`
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894150327


   **[Test build #142156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142156/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895779492


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46764/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894218281


   **[Test build #142161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142161/testReport)** for PR 33661 at commit [`7669b25`](https://github.com/apache/spark/commit/7669b25a04e79e14b39c2b9a7580689315f26aee).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895731933


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46761/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895363909


   **[Test build #142233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142233/testReport)** for PR 33661 at commit [`582bdb2`](https://github.com/apache/spark/commit/582bdb2e69926431863c6a9bfa4db3394488da20).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894815765


   **[Test build #142198 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142198/testReport)** for PR 33661 at commit [`38c6857`](https://github.com/apache/spark/commit/38c6857a3d58b18be272459026980e7de5682c79).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894337945


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46672/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685091352



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -656,6 +656,8 @@ abstract class TypeCoercionBase {
       (leftType, rightType) match {
         case (_: DecimalType, NullType) => true
         case (NullType, _: DecimalType) => true
+        case (_: DayTimeIntervalType, _: DayTimeIntervalType) => true
+        case (_: YearMonthIntervalType, _: YearMonthIntervalType) => true

Review comment:
       Removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685372007



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,47 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;

Review comment:
       You can test more combinations in `TypeCoercionSuite`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685727549



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,15 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1 02' DAY TO HOUR = INTERVAL '02:10:55' HOUR TO SECOND;
+SELECT INTERVAL '1' YEAR < INTERVAL '1' MONTH;
+SELECT INTERVAL '-1-1' YEAR TO MONTH = INTERVAL '-13' MONTH;
+SELECT INTERVAL 1 MONTH > INTERVAL 20 DAYS;
+
+SELECT array(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
+SELECT array(INTERVAL '1' DAY, INTERVAL '01:01' HOUR TO MINUTE);
+SELECT coalesce(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
+SELECT coalesce(INTERVAL '1' DAY, INTERVAL '01:01' HOUR TO MINUTE);
+SELECT coalesce(INTERVAL 1 MONTH, INTERVAL 20 DAYS);

Review comment:
       don't miss the `array(...)` test case




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685342943



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AnsiTypeCoercion.scala
##########
@@ -120,6 +121,15 @@ object AnsiTypeCoercion extends TypeCoercionBase {
     case (_: TimestampType, _: DateType) | (_: DateType, _: TimestampType) =>
       Some(TimestampType)
 
+    case (t1: DayTimeIntervalType, t2: DayTimeIntervalType) =>
+      Some(DayTimeIntervalType(
+        IntervalUtils.minAnsiIntervalField(t1.startField, t2.startField),

Review comment:
       just `t1.startField.min(t2.startField)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895395550


   **[Test build #142234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142234/testReport)** for PR 33661 at commit [`667f1da`](https://github.com/apache/spark/commit/667f1da9cbd02e54488ddb20ecc4061d730d521f).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893964746


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46633/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895820977


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46764/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895140539


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142224/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894056958


   **[Test build #142141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142141/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684783328



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -840,10 +840,17 @@ abstract class BinaryComparison extends BinaryOperator with Predicate {
 
   final override val nodePatterns: Seq[TreePattern] = Seq(BINARY_COMPARISON)
 
-  override def checkInputDataTypes(): TypeCheckResult = super.checkInputDataTypes() match {
-    case TypeCheckResult.TypeCheckSuccess =>
-      TypeUtils.checkForOrderingExpr(left.dataType, this.getClass.getSimpleName)
-    case failure => failure
+  override def checkInputDataTypes(): TypeCheckResult = {
+    val matched = (left.dataType, right.dataType) match {
+      case (l: DayTimeIntervalType, r: DayTimeIntervalType) => TypeCheckResult.TypeCheckSuccess

Review comment:
       > It's a bit weird that we allow different types in binary comparison. Can we fix the type coercion instead? e.g. `TypeCoercion.findTightestCommonType`. This is also more general, we can also support `coalesce(interval1, interval2)`
   
   Hmm like current?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893981751


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46633/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895677622


   **[Test build #142250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142250/testReport)** for PR 33661 at commit [`74ccdad`](https://github.com/apache/spark/commit/74ccdad6441a0477980a08ac1579712764bc240d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895139483


   **[Test build #142225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142225/testReport)** for PR 33661 at commit [`5c14f76`](https://github.com/apache/spark/commit/5c14f76561508c374e71794ac2231d01d70a11d3).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895677622


   **[Test build #142250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142250/testReport)** for PR 33661 at commit [`74ccdad`](https://github.com/apache/spark/commit/74ccdad6441a0477980a08ac1579712764bc240d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894150327


   **[Test build #142156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142156/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895436149


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46746/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895390979


   **[Test build #142234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142234/testReport)** for PR 33661 at commit [`667f1da`](https://github.com/apache/spark/commit/667f1da9cbd02e54488ddb20ecc4061d730d521f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893997101


   **[Test build #142122 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142122/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895432457


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46745/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894218281


   **[Test build #142161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142161/testReport)** for PR 33661 at commit [`7669b25`](https://github.com/apache/spark/commit/7669b25a04e79e14b39c2b9a7580689315f26aee).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895467327


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46746/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685665527



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,47 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;

Review comment:
       > You can test more combinations in `TypeCoercionSuite`
   
   Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895140539


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142224/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894209493


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142156/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895363909


   **[Test build #142233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142233/testReport)** for PR 33661 at commit [`582bdb2`](https://github.com/apache/spark/commit/582bdb2e69926431863c6a9bfa4db3394488da20).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895465038


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46746/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894207997


   **[Test build #142156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142156/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894821433


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46710/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895932828


   **[Test build #142257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142257/testReport)** for PR 33661 at commit [`f0117a6`](https://github.com/apache/spark/commit/f0117a6c17d4c683431f6426024aaa5dc0f53aba).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685108191



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,28 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;

Review comment:
       > let's focus on different fields, not different binary operators.
   
   I think current can cover all the case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894053931


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894125441


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142141/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894000248


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142122/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684999524



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -656,6 +656,8 @@ abstract class TypeCoercionBase {
       (leftType, rightType) match {
         case (_: DecimalType, NullType) => true
         case (NullType, _: DecimalType) => true
+        case (_: DayTimeIntervalType, _: DayTimeIntervalType) => true
+        case (_: YearMonthIntervalType, _: YearMonthIntervalType) => true

Review comment:
       why do we need this? the default case should work for interval types




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894361386


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46672/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895693418


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46756/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895715081


   **[Test build #142254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142254/testReport)** for PR 33661 at commit [`19f5661`](https://github.com/apache/spark/commit/19f5661fd43692afb08b1764a683e74612d412bf).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894393761


   **[Test build #142159 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142159/testReport)** for PR 33661 at commit [`fbd6b1c`](https://github.com/apache/spark/commit/fbd6b1cbd10860b94c4c84fe3f04618d897983f9).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893951128


   **[Test build #142122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142122/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894077637


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46653/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894389920


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46673/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894209493


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142156/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894395150


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142159/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895712343


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46756/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684888789



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -840,10 +840,17 @@ abstract class BinaryComparison extends BinaryOperator with Predicate {
 
   final override val nodePatterns: Seq[TreePattern] = Seq(BINARY_COMPARISON)
 
-  override def checkInputDataTypes(): TypeCheckResult = super.checkInputDataTypes() match {
-    case TypeCheckResult.TypeCheckSuccess =>
-      TypeUtils.checkForOrderingExpr(left.dataType, this.getClass.getSimpleName)
-    case failure => failure
+  override def checkInputDataTypes(): TypeCheckResult = {
+    val matched = (left.dataType, right.dataType) match {
+      case (l: DayTimeIntervalType, r: DayTimeIntervalType) => TypeCheckResult.TypeCheckSuccess

Review comment:
       > It's a bit weird that we allow different types in binary comparison. Can we fix the type coercion instead? e.g. `TypeCoercion.findTightestCommonType`. This is also more general, we can also support `coalesce(interval1, interval2)`
   
   If not change here, `checkInputDataTypes` will be false and expression is not resolved for  below UT.
   ```
    checkEvaluation(EqualTo(
         Literal.create(10,
           YearMonthIntervalType(YearMonthIntervalType.YEAR, YearMonthIntervalType.MONTH)),
         Literal.create(10,
           YearMonthIntervalType(YearMonthIntervalType.MONTH, YearMonthIntervalType.MONTH))), true)
   ```
   If reasonable? or should I just remove the UT
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895283407


   Kubernetes integration test unable to build dist.
   
   exiting with code: 141
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46737/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894317832


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46669/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895167437






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895475891


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46745/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894395150


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142159/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894124647


   **[Test build #142141 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142141/testReport)** for PR 33661 at commit [`6a67d04`](https://github.com/apache/spark/commit/6a67d04257cbaa507269be9f8542d71bf06e1a6e).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894398232


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142161/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684147182



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,8 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1' YEAR = INTERVAL '1' MONTH;
+SELECT INTERVAL '1-1' YEAR TO MONTH = INTERVAL '13' MONTH;
+SELECT INTERVAL '13' MONTH > INTERVAL '1' YEAR;

Review comment:
       Could you add more tests:
   - At least, every supported ANSI interval type should be tested
   - More compare ops
   - Negative, 0, positive intervals
   - Negative tests
   - Comparison of year-month with day-time intervals (should fail).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895814662


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46767/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685001041



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,28 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;

Review comment:
       let's focus on different fields, not different binary operators.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894212288


   **[Test build #142159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142159/testReport)** for PR 33661 at commit [`fbd6b1c`](https://github.com/apache/spark/commit/fbd6b1cbd10860b94c4c84fe3f04618d897983f9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894821450


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46710/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894398232


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142161/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895712369


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46756/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895135839


   **[Test build #142224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142224/testReport)** for PR 33661 at commit [`ee80531`](https://github.com/apache/spark/commit/ee80531448dbf6075daa2191d87be86a5b91eebe).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894125441


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142141/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk closed pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #33661:
URL: https://github.com/apache/spark/pull/33661


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r684998953



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -867,6 +869,9 @@ object TypeCoercion extends TypeCoercionBase {
       case (_: TimestampType, _: DateType) | (_: DateType, _: TimestampType) =>
         Some(TimestampType)
 
+      case (_: DayTimeIntervalType, _: DayTimeIntervalType) => Some(DayTimeIntervalType())
+      case (_: YearMonthIntervalType, _: YearMonthIntervalType) => Some(YearMonthIntervalType())

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895754833


   **[Test build #142257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142257/testReport)** for PR 33661 at commit [`f0117a6`](https://github.com/apache/spark/commit/f0117a6c17d4c683431f6426024aaa5dc0f53aba).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685706819



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,13 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1 02' DAY TO HOUR = INTERVAL '02:10:55' HOUR TO SECOND;
+SELECT INTERVAL '1' YEAR < INTERVAL '1' MONTH;
+SELECT INTERVAL '-1-1' YEAR TO MONTH = INTERVAL '-13' MONTH;

Review comment:
       let's add a negative test as well
   ```
   SELECT INTERVAL 1 MONTH > INTERVAL 20 DAYS;
   ```

##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,13 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;
+SELECT INTERVAL '1 02' DAY TO HOUR = INTERVAL '02:10:55' HOUR TO SECOND;
+SELECT INTERVAL '1' YEAR < INTERVAL '1' MONTH;
+SELECT INTERVAL '-1-1' YEAR TO MONTH = INTERVAL '-13' MONTH;
+
+SELECT array(INTERVAL '1' YEAR, INTERVAL '1' MONTH);
+SELECT array(INTERVAL '1' DAY, '01:01' HOUR TO MINUTE);
+SELECT coalesce(INTERVAL '1' YEAR, INTERVAL '1' MONTH);

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894361386


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46672/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895754065


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46761/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894389920


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46673/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894212288


   **[Test build #142159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142159/testReport)** for PR 33661 at commit [`fbd6b1c`](https://github.com/apache/spark/commit/fbd6b1cbd10860b94c4c84fe3f04618d897983f9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894396621


   **[Test build #142161 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142161/testReport)** for PR 33661 at commit [`7669b25`](https://github.com/apache/spark/commit/7669b25a04e79e14b39c2b9a7580689315f26aee).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class BlockSavedOnDecommissionedBlockManagerException(blockId: BlockId)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894383907


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46673/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-893981751


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46633/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #33661:
URL: https://github.com/apache/spark/pull/33661#discussion_r685107970



##########
File path: sql/core/src/test/resources/sql-tests/inputs/interval.sql
##########
@@ -322,3 +322,28 @@ SELECT INTERVAL '153722867280' MINUTE;
 SELECT INTERVAL '-153722867280' MINUTE;
 SELECT INTERVAL '54.775807' SECOND;
 SELECT INTERVAL '-54.775807' SECOND;
+
+SELECT INTERVAL '1' DAY > INTERVAL '1' HOUR;

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894818293


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142198/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894179254


   @AngersZhuuuu Thank you for the ping. Unfortunately, I cannot review it at the moment. @cloud-fan @sarutak @beliefer @Peng-Lei Could you review this PR, please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894361279


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46672/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895395592


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142234/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895754833


   **[Test build #142257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142257/testReport)** for PR 33661 at commit [`f0117a6`](https://github.com/apache/spark/commit/f0117a6c17d4c683431f6426024aaa5dc0f53aba).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894359142


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46673/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-894816154


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46710/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895744670


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46761/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support comparison of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895351204


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46737/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33661: [SPARK-36431][SQL] Support TypeCoercion of ANSI intervals with different fields

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33661:
URL: https://github.com/apache/spark/pull/33661#issuecomment-895475956


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46745/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org