You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/03 11:12:21 UTC
[kudu-CR] KUDU-237 (part 4) - Account for reinserts in delta stats
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4932
Change subject: KUDU-237 (part 4) - Account for reinserts in delta stats
......................................................................
KUDU-237 (part 4) - Account for reinserts in delta stats
This makes DeltaStats also account for REINSERTs. This is needed to
properly schedule compactions (need to account for the updated
columns in REINSERTs).
Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
---
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/delta_stats.h
M src/kudu/tablet/tablet.proto
3 files changed, 42 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4932/1
--
To view, visit http://gerrit.cloudera.org:8080/4932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Account for REINSERTs in delta stats
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Account for REINSERTs in delta stats
......................................................................
Account for REINSERTs in delta stats
This makes DeltaStats also account for REINSERTs. This is not
actually used outside of tests, but seems like it would be
silly to not count this type of delta. In the future it might
be useful for selecting undo deltas for minor delta compaction.
The protobuf field is optional to preserve data format
compatibility.
Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
Reviewed-on: http://gerrit.cloudera.org:8080/4932
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/delta_stats.h
M src/kudu/tablet/tablet.proto
3 files changed, 46 insertions(+), 15 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Account for REINSERTs in delta stats
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4932
to look at the new patch set (#2).
Change subject: Account for REINSERTs in delta stats
......................................................................
Account for REINSERTs in delta stats
This makes DeltaStats also account for REINSERTs. This is not
actually used outside of tests, but seems like it would be
silly to not count this type of delta. In the future it might
be useful for selecting undo deltas for minor delta compaction.
The protobuf field is optional to preserve data format
compatibility.
Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
---
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/delta_stats.h
M src/kudu/tablet/tablet.proto
3 files changed, 43 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4932/2
--
To view, visit http://gerrit.cloudera.org:8080/4932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Account for REINSERTs in delta stats
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4932
to look at the new patch set (#3).
Change subject: Account for REINSERTs in delta stats
......................................................................
Account for REINSERTs in delta stats
This makes DeltaStats also account for REINSERTs. This is not
actually used outside of tests, but seems like it would be
silly to not count this type of delta. In the future it might
be useful for selecting undo deltas for minor delta compaction.
The protobuf field is optional to preserve data format
compatibility.
Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
---
M src/kudu/tablet/delta_stats.cc
M src/kudu/tablet/delta_stats.h
M src/kudu/tablet/tablet.proto
3 files changed, 46 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/4932/3
--
To view, visit http://gerrit.cloudera.org:8080/4932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Account for REINSERTs in delta stats
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Account for REINSERTs in delta stats
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd60f6c1c12803d339f5f8d96c6b089fab21b13f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No