You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "betodealmeida (via GitHub)" <gi...@apache.org> on 2023/06/29 21:53:37 UTC
[GitHub] [superset] betodealmeida opened a new pull request, #24558: Styling custom width
betodealmeida opened a new pull request, #24558:
URL: https://github.com/apache/superset/pull/24558
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Improve styling of the alerts/reports modal.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #24558: chore: better styling alerts/reports modal
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #24558:
URL: https://github.com/apache/superset/pull/24558#discussion_r1247266964
##########
superset/migrations/versions/2023-06-29_18-38_240d23c7f86f_update_tag_model_w_description.py:
##########
@@ -17,14 +17,14 @@
"""update_tag_model_w_description
Revision ID: 240d23c7f86f
-Revises: 6fbe660cac39
+Revises: 8e5b0fb85b9a
Review Comment:
What's this fixing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24558: chore: better styling alerts/reports modal
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24558:
URL: https://github.com/apache/superset/pull/24558#issuecomment-1613863047
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24558?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24558](https://app.codecov.io/gh/apache/superset/pull/24558?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6e9d4ca) into [master](https://app.codecov.io/gh/apache/superset/commit/be9eb0f3a3c2d33ab6a1794ff36a4ee3f6b3a28b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (be9eb0f) will **increase** coverage by `2.85%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 6e9d4ca differs from pull request most recent head a300aaf. Consider uploading reports for the commit a300aaf to get more accurate results
```diff
@@ Coverage Diff @@
## master #24558 +/- ##
==========================================
+ Coverage 55.26% 58.11% +2.85%
==========================================
Files 1906 1906
Lines 74137 74135 -2
Branches 8154 8154
==========================================
+ Hits 40970 43086 +2116
+ Misses 31048 28930 -2118
Partials 2119 2119
```
| Flag | Coverage Δ | |
|---|---|---|
| presto | `53.84% <ø> (?)` | |
| python | `60.64% <ø> (+5.94%)` | :arrow_up: |
| unit | `54.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/features/alerts/AlertReportModal.tsx](https://app.codecov.io/gh/apache/superset/pull/24558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2FsZXJ0cy9BbGVydFJlcG9ydE1vZGFsLnRzeA==) | `54.24% <ø> (-0.25%)` | :arrow_down: |
... and [79 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24558/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a diff in pull request #24558: chore: better styling alerts/reports modal
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on code in PR #24558:
URL: https://github.com/apache/superset/pull/24558#discussion_r1247268040
##########
superset/migrations/versions/2023-06-29_18-38_240d23c7f86f_update_tag_model_w_description.py:
##########
@@ -17,14 +17,14 @@
"""update_tag_model_w_description
Revision ID: 240d23c7f86f
-Revises: 6fbe660cac39
+Revises: 8e5b0fb85b9a
Review Comment:
We currently have 2 heads in Alembic, this chains the 2 (independent heads) so there's just one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #24558: chore: better styling alerts/reports modal
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida merged PR #24558:
URL: https://github.com/apache/superset/pull/24558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org