You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/10 03:22:39 UTC
[GitHub] [flink] sunjincheng121 commented on a change in pull request #8532:
[FLINK-12541][REST] Support to submit Python Table API jobs via REST API
sunjincheng121 commented on a change in pull request #8532: [FLINK-12541][REST] Support to submit Python Table API jobs via REST API
URL: https://github.com/apache/flink/pull/8532#discussion_r291865173
##########
File path: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/ArtifactPlanHandlerParameterTest.java
##########
@@ -56,13 +57,13 @@ public static void setup() throws Exception {
}
@Override
- JarPlanMessageParameters getUnresolvedJarMessageParameters() {
+ ArtifactPlanMessageParameters getUnresolvedJarMessageParameters() {
return handler.getMessageHeaders().getUnresolvedMessageParameters();
}
@Override
- JarPlanMessageParameters getJarMessageParameters(ProgramArgsParType programArgsParType) {
- final JarPlanMessageParameters parameters = getUnresolvedJarMessageParameters();
+ ArtifactPlanMessageParameters getJarMessageParameters(ProgramArgsParType programArgsParType) {
Review comment:
`getJarMessageParameters` -> `getArtifactMessageParameters`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services