You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/12 09:29:28 UTC
[GitHub] Matrix42 commented on a change in pull request #7287:
[FLINK-11140][streaming] Fix empty child path check in Buckets
Matrix42 commented on a change in pull request #7287: [FLINK-11140][streaming] Fix empty child path check in Buckets
URL: https://github.com/apache/flink/pull/7287#discussion_r240936910
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -304,6 +304,10 @@ void close() {
}
private Path assembleBucketPath(BucketID bucketId) {
+ String child = bucketId.toString();
+ if ("".equals(child)) {
+ return basePath;
+ }
return new Path(basePath, bucketId.toString());
Review comment:
@yanghua thanks for your review, i will fix this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services