You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/04/23 16:47:30 UTC
[GitHub] [solr] bszabo97 opened a new pull request #92: SOLR-15067 Child doc transformer should use the perSegFilter cache
bszabo97 opened a new pull request #92:
URL: https://github.com/apache/solr/pull/92
Change-Id: I6cc22a9e13aeaef37a1e005b111a59bb7412023d
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
The ChildDocTransformerFactory creates a QueryBitSetProducer every time. These are heavy to compute; they should be cached. BlockJoinParentQParserPlugin does this correctly, using the "perSegFilter" named Solr cache.
# Solution
The solution for this was to copy the implementation of the cache usage from BlockJoinParentQParser. We decided not to create a new class for this since the solution was quite simple
# Tests
Unit tests.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] bszabo97 commented on pull request #92: SOLR-15067 Child doc transformer should use the perSegFilter cache
Posted by GitBox <gi...@apache.org>.
bszabo97 commented on pull request #92:
URL: https://github.com/apache/solr/pull/92#issuecomment-826299575
I have added a new commit which contains the new entry in the CHANGES.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #92: SOLR-15067 Child doc transformer should use the perSegFilter cache
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #92:
URL: https://github.com/apache/solr/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] bszabo97 commented on pull request #92: SOLR-15067 Child doc transformer should use the perSegFilter cache
Posted by GitBox <gi...@apache.org>.
bszabo97 commented on pull request #92:
URL: https://github.com/apache/solr/pull/92#issuecomment-826299575
I have added a new commit which contains the new entry in the CHANGES.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #92: SOLR-15067 Child doc transformer should use the perSegFilter cache
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #92:
URL: https://github.com/apache/solr/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org