You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2009/02/20 21:45:53 UTC

Re: copy with --parents creates bogus folder

Was this looked into?  Fixed?  Filed to the tracker?

Stefan Küng wrote on Thu, 8 Jan 2009 at 18:39 +0100:
> Hi,
> 
> To reproduce, first create empty repository, served via apache. Then:
> 
> svn mkdir http://server/trunk/Földer -m "create folder with non-ascii
> char in name"
> 
> svn co http://server/trunk wc
> echo dummy > wc\föle.txt
> svn add wc\föle.txt
> svn ci wc -m "add file with non-ascii char in name"
> svn cp http://server/trunk/föle.txt http://server/trunk/Földer/föle.txt
> --parents -m "copy file"
> svn list http://server/trunk
> Földer
> F%C3%B6lder
> föle.txt
> 
> 
> What I would expect is that the file "föle.txt" is copied to the
> existing folder "Földer", but what actually happens is that a new folder
> is created with name "F%C3%B6lder".
> 
> 
> This happens both with 1.5.x and a trunk build.
> 
> Note: I don't think the cause is the url escaping in the command line
> client, since the same happens in TSVN where I just checked that the
> urls are passed to svn_client_copy properly escaped.
> 
> Stefan
> 
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1200675

Re: copy with --parents creates bogus folder

Posted by Stefan Küng <to...@gmail.com>.
Bert Huijben wrote:
>> -----Original Message-----
>> From: Bert Huijben [mailto:rhuijben@sharpsvn.net]
>> Sent: Tuesday, February 24, 2009 9:56 PM
>> To: 'Stefan Küng'; 'Daniel Shahaf'
>> Cc: dev@subversion.tigris.org
>> Subject: RE: copy with --parents creates bogus folder
>>
>>> -----Original Message-----
>>> From: Stefan Küng [mailto:tortoisesvn@gmail.com]
>>> Sent: Friday, February 20, 2009 11:02 PM
>>> To: Daniel Shahaf
>>> Cc: dev@subversion.tigris.org
>>> Subject: Re: copy with --parents creates bogus folder
>>>
>>>>> What I would expect is that the file "föle.txt" is copied to the
>>>>> existing folder "Földer", but what actually happens is that a new
>>> folder
>>>>> is created with name "F%C3%B6lder".
>>>>>
> 
> 
>> I opened issue 3374 to keep this issue alive.
>> http://subversion.tigris.org/issues/show_bug.cgi?id=3374
> 
> 	Stefan,
> 
> Can you confirm that r36106 resolves this issue?

Yes, this fixes the issue for me. Thanks!
Now testing the fix with an 1.5.x build...

Stefan


-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1227883

Re: copy with --parents creates bogus folder

Posted by Stefan Küng <to...@gmail.com>.
Bert Huijben wrote:
>> -----Original Message-----
>> From: Bert Huijben [mailto:rhuijben@sharpsvn.net]
>> Sent: Tuesday, February 24, 2009 9:56 PM
>> To: 'Stefan Küng'; 'Daniel Shahaf'
>> Cc: dev@subversion.tigris.org
>> Subject: RE: copy with --parents creates bogus folder
>>
>>> -----Original Message-----
>>> From: Stefan Küng [mailto:tortoisesvn@gmail.com]
>>> Sent: Friday, February 20, 2009 11:02 PM
>>> To: Daniel Shahaf
>>> Cc: dev@subversion.tigris.org
>>> Subject: Re: copy with --parents creates bogus folder
>>>
>>>>> What I would expect is that the file "föle.txt" is copied to the
>>>>> existing folder "Földer", but what actually happens is that a new
>>> folder
>>>>> is created with name "F%C3%B6lder".
>>>>>
> 
> 
>> I opened issue 3374 to keep this issue alive.
>> http://subversion.tigris.org/issues/show_bug.cgi?id=3374
> 
> 	Stefan,
> 
> Can you confirm that r36106 resolves this issue?

Will do tomorrow - just wanted to log off for the night.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1222754

RE: copy with --parents creates bogus folder

Posted by Bert Huijben <rh...@sharpsvn.net>.
> -----Original Message-----
> From: Bert Huijben [mailto:rhuijben@sharpsvn.net]
> Sent: Tuesday, February 24, 2009 9:56 PM
> To: 'Stefan Küng'; 'Daniel Shahaf'
> Cc: dev@subversion.tigris.org
> Subject: RE: copy with --parents creates bogus folder
> 
> > -----Original Message-----
> > From: Stefan Küng [mailto:tortoisesvn@gmail.com]
> > Sent: Friday, February 20, 2009 11:02 PM
> > To: Daniel Shahaf
> > Cc: dev@subversion.tigris.org
> > Subject: Re: copy with --parents creates bogus folder
> >
> 
> > >> What I would expect is that the file "föle.txt" is copied to the
> > >> existing folder "Földer", but what actually happens is that a new
> > folder
> > >> is created with name "F%C3%B6lder".
> > >>


> I opened issue 3374 to keep this issue alive.
> http://subversion.tigris.org/issues/show_bug.cgi?id=3374

	Stefan,

Can you confirm that r36106 resolves this issue?

> 	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1222751


RE: copy with --parents creates bogus folder

Posted by Bert Huijben <rh...@sharpsvn.net>.
> -----Original Message-----
> From: Stefan Küng [mailto:tortoisesvn@gmail.com]
> Sent: Friday, February 20, 2009 11:02 PM
> To: Daniel Shahaf
> Cc: dev@subversion.tigris.org
> Subject: Re: copy with --parents creates bogus folder
> 

> >> What I would expect is that the file "föle.txt" is copied to the
> >> existing folder "Földer", but what actually happens is that a new
> folder
> >> is created with name "F%C3%B6lder".
> >>
> >>
> >> This happens both with 1.5.x and a trunk build.
> >>
> >> Note: I don't think the cause is the url escaping in the command
> line
> >> client, since the same happens in TSVN where I just checked that the
> >> urls are passed to svn_client_copy properly escaped.
> 
> Just tested again with an 1.6.x build. Still the same.

I reproduced this issue with a 1.6.0-rc2 client and a 1.5.5 http server.

I opened issue 3374 to keep this issue alive.
http://subversion.tigris.org/issues/show_bug.cgi?id=3374

	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1222452


Re: copy with --parents creates bogus folder

Posted by Stefan Küng <to...@gmail.com>.
Daniel Shahaf wrote:
> Was this looked into?  Fixed?  Filed to the tracker?
> 
> Stefan Küng wrote on Thu, 8 Jan 2009 at 18:39 +0100:
>> Hi,
>>
>> To reproduce, first create empty repository, served via apache. Then:
>>
>> svn mkdir http://server/trunk/Földer -m "create folder with non-ascii
>> char in name"
>>
>> svn co http://server/trunk wc
>> echo dummy > wc\föle.txt
>> svn add wc\föle.txt
>> svn ci wc -m "add file with non-ascii char in name"
>> svn cp http://server/trunk/föle.txt http://server/trunk/Földer/föle.txt
>> --parents -m "copy file"
>> svn list http://server/trunk
>> Földer
>> F%C3%B6lder
>> föle.txt
>>
>>
>> What I would expect is that the file "föle.txt" is copied to the
>> existing folder "Földer", but what actually happens is that a new folder
>> is created with name "F%C3%B6lder".
>>
>>
>> This happens both with 1.5.x and a trunk build.
>>
>> Note: I don't think the cause is the url escaping in the command line
>> client, since the same happens in TSVN where I just checked that the
>> urls are passed to svn_client_copy properly escaped.

Just tested again with an 1.6.x build. Still the same.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1200765