You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "xuziyang (via GitHub)" <gi...@apache.org> on 2023/07/05 12:58:04 UTC
[GitHub] [shenyu] xuziyang opened a new pull request, #4806: [ISSUE #4686] ZookeeperClientRegisterRepository active offline
xuziyang opened a new pull request, #4806:
URL: https://github.com/apache/shenyu/pull/4806
[ISSUE #4686] ZookeeperClientRegisterRepository active offline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang merged pull request #4806: [ISSUE #4686] ZookeeperClientRegisterRepository active offline
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang merged PR #4806:
URL: https://github.com/apache/shenyu/pull/4806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4806: [ISSUE #4686] ZookeeperClientRegisterRepository active offline
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4806:
URL: https://github.com/apache/shenyu/pull/4806#issuecomment-1622880086
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4806?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4806](https://app.codecov.io/gh/apache/shenyu/pull/4806?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b2e421b) into [master](https://app.codecov.io/gh/apache/shenyu/commit/1c21ed090220d13404a60cd516c8c1f0aed7a46f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1c21ed0) will **decrease** coverage by `0.21%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head b2e421b differs from pull request most recent head 0fc17dc. Consider uploading reports for the commit 0fc17dc to get more accurate results
```diff
@@ Coverage Diff @@
## master #4806 +/- ##
============================================
- Coverage 65.32% 65.11% -0.21%
+ Complexity 8184 8149 -35
============================================
Files 1138 1138
Lines 33469 33455 -14
Branches 2975 2972 -3
============================================
- Hits 21862 21783 -79
- Misses 9882 9941 +59
- Partials 1725 1731 +6
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...eeper/ZookeeperClientServerRegisterRepository.java](https://app.codecov.io/gh/apache/shenyu/pull/4806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50LXNlcnZlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9yZWdpc3Rlci9jbGllbnQvc2VydmVyL3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRTZXJ2ZXJSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `91.66% <75.00%> (+2.47%)` | :arrow_up: |
... and [49 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4806/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] xuziyang commented on pull request #4806: [ISSUE #4686] ZookeeperClientRegisterRepository active offline
Posted by "xuziyang (via GitHub)" <gi...@apache.org>.
xuziyang commented on PR #4806:
URL: https://github.com/apache/shenyu/pull/4806#issuecomment-1624483162
> need impl `offline` for `ZookeeperClientRegisterRepository`.
Personally, I believe that there is no need to implement the offline () method for the following reasons:
When the client side service stops, ShenyuClientShutdownHook will be triggered, which will close zkClient. After closing zkClient, the registered URI information will naturally be deleted by zk, and shenyu admin can sense the offline of the service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang commented on pull request #4806: [ISSUE #4686] ZookeeperClientRegisterRepository active offline
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang commented on PR #4806:
URL: https://github.com/apache/shenyu/pull/4806#issuecomment-1623962148
need impl `offline` for `ZookeeperClientRegisterRepository`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org