You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/18 18:55:47 UTC

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4706: Improve logs on KVMHostActivityChecker

GutoVeronezi commented on pull request #4706:
URL: https://github.com/apache/cloudstack/pull/4706#issuecomment-781563667


   > Overall code looks good; most of the changes regard adding logs while keeping the core behavior of the execution flow.
   > 
   > I would like just to bring another option to enhance the logs: what do you think of adding the host's name combined (or not) with the host ID?
   > 
   > In my opinion, this would make it easier to find the problematic host in a blink of an eye, otherwise, there is the need of checking via DB/API to find which host has the respective ID.
   
   @GabrielBrascher as you suggested, I added more host information to the log.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org