You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "haridsv (via GitHub)" <gi...@apache.org> on 2023/08/28 10:52:03 UTC

[GitHub] [phoenix] haridsv opened a new pull request, #1662: PHOENIX-7001 Shallow grammar support for CREATE CDC

haridsv opened a new pull request, #1662:
URL: https://github.com/apache/phoenix/pull/1662

   This PR introduces basic shallow support for CREATE CDC grammar. It is being tested using UTs, but execution from a client will generate an NPE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] gjacoby126 commented on a diff in pull request #1662: PHOENIX-7008 Shallow grammar support for CREATE CDC

Posted by "gjacoby126 (via GitHub)" <gi...@apache.org>.
gjacoby126 commented on code in PR #1662:
URL: https://github.com/apache/phoenix/pull/1662#discussion_r1311854132


##########
phoenix-core/src/main/java/org/apache/phoenix/parse/CreateCDCStatement.java:
##########
@@ -0,0 +1,65 @@
+package org.apache.phoenix.parse;

Review Comment:
   @haridsv could you please add an Apache license here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani commented on pull request #1662: PHOENIX-7008 Shallow grammar support for CREATE CDC

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #1662:
URL: https://github.com/apache/phoenix/pull/1662#issuecomment-1722155042

   @gjacoby126 does the latest revision look good to you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [phoenix] virajjasani merged pull request #1662: PHOENIX-7008 Shallow grammar support for CREATE CDC

Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #1662:
URL: https://github.com/apache/phoenix/pull/1662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org