You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/07 12:26:22 UTC

[GitHub] twalthr opened a new pull request #6671: [FLINK-10281] [table] Fix string literal parsing in Table API

twalthr opened a new pull request #6671: [FLINK-10281] [table] Fix string literal parsing in Table API
URL: https://github.com/apache/flink/pull/6671
 
 
   ## What is the purpose of the change
   
   This PR fixes the string literal parsing of the Table API. Proper escaping of the quotes was not possible in the past. The logic was overly complicated and was not handling escaping correctly. The new logic relies on the Java/Scala programs escaping and uses duplicate quotes for escaping the quotes (see the docs).
   
   ## Brief change log
   
   - Rework of the string literals for `ExpressionParser`
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - `org.apache.flink.table.expressions.LiteralTest#testStringLiterals`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? docs
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services