You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/05/30 08:04:05 UTC
[GitHub] [hadoop] elek commented on a change in pull request #868: HDDS-1568
: Add RocksDB metrics to OM.
elek commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM.
URL: https://github.com/apache/hadoop/pull/868#discussion_r288895769
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStoreBuilder.java
##########
@@ -187,7 +196,13 @@ private DBOptions getDbProfile() {
if (option == null) {
LOG.info("Using default options. {}", dbProfile.toString());
- return dbProfile.getDBOptions();
+ option = dbProfile.getDBOptions();
+ }
+
+ if (!rocksDbStat.equals(OZONE_METADATA_STORE_ROCKSDB_STATISTICS_OFF)) {
Review comment:
I am not familiar with the old issue, but now our classpath is separated from yarn. We can use any newer rocksdb (but we should use the same versions for all the hdds/ozone projects)
I think it's safe to use any new rocksdb feature if you think metrics should be turned on by default...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org