You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Damien Diederen <dd...@sinenomine.net> on 2019/08/14 17:12:15 UTC
Re: [jira] [Updated] (ZOOKEEPER-1112) Add support for C client for SASL authentication
Greetings, all,
Note sure how notifications work on this project, but in case it did not
pop up on your radar: I have picked up ZOOKEEPER-1112, which was dormant
since 2011, and pushed a first set of patches:
https://github.com/apache/zookeeper/pull/1054
Reviews and/or comments would be very welcome!
Thanks,
Damien Diederen
Re: (ZOOKEEPER-1112) Add support for C client for SASL authentication
Posted by Damien Diederen <dd...@sinenomine.net>.
> I think you added all of them who mostly active on C patches.
Okay—good to know!
> Facebook folks might also be interested, but they use their own C
> client as far as I’m concerned.
Ah? Interesting.
> I’ll take a look soon.
Thanks! (My goal was not to put pressure on you, though; just to make
sure I was not missing something obvious wrt. maintainers.)
Cheers, -D
>> On 2019. Nov 13., at 19:40, Damien Diederen <dd...@sinenomine.net> wrote:
>>
>>
>> I wrote:
>>
>>>> I have now submitted a new [PR], in which the C library implements SASL
>>>> authentication in a way reminiscent of the Java client:
>>>>
>>>> https://github.com/apache/zookeeper/pull/1134
>>
>> Andor wrote:
>>
>>> Great stuff!!
>>
>> Thank you, Andor! (And to Ted, who commented on an earlier email.)
>>
>> Would you happen to know who is actively using the C client, and would
>> have an incentive to review such changes? There is no particular
>> urgency, but it would be good to keep the momentum going if possible.
>>
>> (I have tried "pinging" earliers maintainers of these areas from GitHub
>> PRs, but they do not seem to be active on that front.)
>>
>> Thanks, -D
Re: (ZOOKEEPER-1112) Add support for C client for SASL authentication
Posted by Andor Molnar <an...@apache.org>.
I think you added all of them who mostly active on C patches.
Facebook folks might also be interested, but they use their own C client as far as I’m concerned.
I’ll take a look soon.
Andor
> On 2019. Nov 13., at 19:40, Damien Diederen <dd...@sinenomine.net> wrote:
>
>
> I wrote:
>
>>> I have now submitted a new [PR], in which the C library implements SASL
>>> authentication in a way reminiscent of the Java client:
>>>
>>> https://github.com/apache/zookeeper/pull/1134
>
> Andor wrote:
>
>> Great stuff!!
>
> Thank you, Andor! (And to Ted, who commented on an earlier email.)
>
> Would you happen to know who is actively using the C client, and would
> have an incentive to review such changes? There is no particular
> urgency, but it would be good to keep the momentum going if possible.
>
> (I have tried "pinging" earliers maintainers of these areas from GitHub
> PRs, but they do not seem to be active on that front.)
>
> Thanks, -D
Re: (ZOOKEEPER-1112) Add support for C client for SASL authentication
Posted by Damien Diederen <dd...@sinenomine.net>.
I wrote:
>> I have now submitted a new [PR], in which the C library implements SASL
>> authentication in a way reminiscent of the Java client:
>>
>> https://github.com/apache/zookeeper/pull/1134
Andor wrote:
> Great stuff!!
Thank you, Andor! (And to Ted, who commented on an earlier email.)
Would you happen to know who is actively using the C client, and would
have an incentive to review such changes? There is no particular
urgency, but it would be good to keep the momentum going if possible.
(I have tried "pinging" earliers maintainers of these areas from GitHub
PRs, but they do not seem to be active on that front.)
Thanks, -D
Re: (ZOOKEEPER-1112) Add support for C client for SASL
authentication
Posted by Andor Molnar <an...@apache.org>.
Great stuff!!
-----Original Message-----
From: Damien Diederen <dd...@sinenomine.net>
Reply-To: dev@zookeeper.apache.org
To: dev@zookeeper.apache.org
Subject: Re: (ZOOKEEPER-1112) Add support for C client for SASL
authentication
Date: Wed, 06 Nov 2019 16:56:57 +0100
Greetings, all,
A while ago, I wrote:
> I have picked up ZOOKEEPER-1112, which was dormant
> since 2011, and pushed a first set of patches:
>
> https://github.com/apache/zookeeper/pull/1054
I ended up "withdrawing" that PR because it suffered from problematic
shortcomings.
I have now submitted a new one, in which the C library implements SASL
authentication in a way reminiscent of the Java client:
https://github.com/apache/zookeeper/pull/1134
I would appreciate reviews, comments or (gasp!) additional testing!
Thanks,
Damien Diederen
P.-S. — Note that I also have a related improvements to cli.c, but they
depend on the resolution of ZOOKEEPER-3599 (use getopt if available);
I am planning to submit them as part of a subsequent PR.
Re: (ZOOKEEPER-1112) Add support for C client for SASL authentication
Posted by Damien Diederen <dd...@sinenomine.net>.
Greetings, all,
A while ago, I wrote:
> I have picked up ZOOKEEPER-1112, which was dormant
> since 2011, and pushed a first set of patches:
>
> https://github.com/apache/zookeeper/pull/1054
I ended up "withdrawing" that PR because it suffered from problematic
shortcomings.
I have now submitted a new one, in which the C library implements SASL
authentication in a way reminiscent of the Java client:
https://github.com/apache/zookeeper/pull/1134
I would appreciate reviews, comments or (gasp!) additional testing!
Thanks,
Damien Diederen
P.-S. — Note that I also have a related improvements to cli.c, but they
depend on the resolution of ZOOKEEPER-3599 (use getopt if available);
I am planning to submit them as part of a subsequent PR.
Re: [jira] [Updated] (ZOOKEEPER-1112) Add support for C client for
SASL authentication
Posted by Ted Dunning <te...@gmail.com>.
Kudos to you for this!
On Wed, Aug 14, 2019 at 10:55 AM Damien Diederen <dd...@sinenomine.net>
wrote:
>
> Greetings, all,
>
> Note sure how notifications work on this project, but in case it did not
> pop up on your radar: I have picked up ZOOKEEPER-1112, which was dormant
> since 2011, and pushed a first set of patches:
>
> https://github.com/apache/zookeeper/pull/1054
>
> Reviews and/or comments would be very welcome!
>
> Thanks,
> Damien Diederen
>