You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/15 15:32:25 UTC

[GitHub] igalshilman opened a new pull request #7496: [FLINK-11323] Upgrade KryoSerializer snapshot to implement new TypeSerializerSnapshot interface

igalshilman opened a new pull request #7496: [FLINK-11323] Upgrade KryoSerializer snapshot to implement new TypeSerializerSnapshot interface
URL: https://github.com/apache/flink/pull/7496
 
 
   ## What is the purpose of the change
   
   This PR migrates the `KryoSerializerConfigSnapshot` to use the new `TypeSerializerSnapshot` API. 
   
   ## Brief change log
   
     - d69528004b - Adds an `OptionalMap`, a data structure, that support `null` values and `null` keys (but named uniquely).  This is needed to remove the previously used `DummyUnloadableClass` and `DummyUnloadableSerializer` that were used to flag that a class/serializer were not successfully loaded. With this map we can simply check for their existence.
     - e476640c41 - Kryo is the first serializer that actually supports reconfiguration with the new API, so some tests needed to be adjusted. 
    - cb058653c2 -  Completes the migration of the KryoSerializer to the new abstraction, by adding and using the new `KryoSerializerSnapshot`.
   
   ## Verifying this change
   
   - *Added `KryoSnapshotMigrationTest` along with some test cases.
     
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
     - The serializers: (**yes** / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services