[GitHub] [doris] HappenLee commented on a diff in pull request #19917: [feature-wip](auto-inc)(step-2) support auto-increment column for duplicate table

["HappenLee (via GitHub)" <gi...@apache.org>]

HappenLee commented on code in PR #19917:
URL: https://github.com/apache/doris/pull/19917#discussion_r1233777785


##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -1049,6 +1175,18 @@ Status VOlapTableSink::prepare(RuntimeState* state) {
         return Status::InternalError("unknown destination tuple descriptor");
     }
 
+    for (size_t idx = 0; idx < _output_tuple_desc->slots().size(); idx++) {
+        if (_output_tuple_desc->slots()[idx]->is_auto_increment()) {
+            _auto_inc_col_idx = idx;
+            _auto_inc_id_buffer = GlobalAutoIncBuffers::GetInstance()->get_auto_inc_buffer(

Review Comment:
   why here need a global Auto Buffer？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org