[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2998: Split out arrow-cast (#2594)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2998:
URL: https://github.com/apache/arrow-rs/pull/2998#discussion_r1014299035


##########
arrow-cast/src/cast.rs:
##########
@@ -302,30 +293,31 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool {
 /// * To or from `StructArray`
 /// * List to primitive
 /// * Interval and duration
-pub fn cast(array: &ArrayRef, to_type: &DataType) -> Result<ArrayRef> {
+pub fn cast(array: &ArrayRef, to_type: &DataType) -> Result<ArrayRef, ArrowError> {
     cast_with_options(array, to_type, &DEFAULT_CAST_OPTIONS)
 }
 
-fn cast_integer_to_decimal128<T: ArrowNumericType>(
+fn cast_integer_to_decimal128<T: ArrowPrimitiveType>(

Review Comment:
   ArrowNumericType is part of the arithmetic kernels which haven't been split out



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org