You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2026/07/07 13:38:31 UTC
[PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
mihailoale-db opened a new pull request, #57081:
URL: https://github.com/apache/spark/pull/57081
### What changes were proposed in this pull request?
To improve message for `UNSUPPORTED_EXPR_FOR_OPERATOR` exception.
### Why are the changes needed?
In order to improve error message.
### Does this PR introduce _any_ user-facing change?
Better error message.
### How was this patch tested?
Testing change.
### Was this patch authored or co-authored using generative AI tooling?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3554004916
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
OK, then use a nested error condition to "roll them up". And you can always have "OTHER" catch up where you expose the the node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3544616748
##########
sql/core/src/test/resources/sql-tests/analyzer-results/order-by-and-having-on-top-of-aggregate-with-join.sql.out:
##########
@@ -2387,7 +2387,8 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException
"errorClass" : "UNSUPPORTED_EXPR_FOR_OPERATOR",
"sqlState" : "42K0E",
"messageParameters" : {
- "invalidExprSqls" : "\"max(col1)\""
+ "invalidExprSqls" : "\"max(col1)\"",
+ "operator" : "Sort"
Review Comment:
```suggestion
"operator" : "ORDER BY"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3544591965
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveSubquerySuite.scala:
##########
@@ -177,7 +177,9 @@ class ResolveSubquerySuite extends AnalysisTest {
assertAnalysisErrorCondition(
plan,
expectedErrorCondition = "UNSUPPORTED_EXPR_FOR_OPERATOR",
- expectedMessageParameters = Map("invalidExprSqls" -> "\"sum(a)\", \"sum(c)\"")
+ expectedMessageParameters = Map(
+ "operator" -> "LateralJoin",
Review Comment:
This should come out as LATERAL (the keyword representing the lateral join)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3554542227
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
I don't see how it's different. Instead of operator -> operation you propose operator -> sub error class. It would be an overkill. Although I agree that it's the right way to do in majority of cases I would say that this one should use operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3554004916
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
OK, then use a nested error condition to "roll them up". And you can always have "OTHER" catch all where you expose the the node.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #57081:
URL: https://github.com/apache/spark/pull/57081#issuecomment-4913441747
@MaxGekk @cloud-fan Could you PTAL at this PR when you find time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #57081:
URL: https://github.com/apache/spark/pull/57081#issuecomment-4975234316
LGTM, merging to master + 4.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3579386985
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
I have no issue with operators. I have an issue withe eposing Scala node names instead of SQL keywords.
Are these operators documents. Do the match the dfataframe APIs at least? If not they have little menaing even for a non-SQL developer.
I am not a committer. I cannot prveent you from merging.
Note that before this endeavor we exposed Java stack traces. Great for developers. Bewildering for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3553780248
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
It would be possible to create a map if this was an allowlist but it's not:
```
def specialExpressionsInUnsupportedOperator(plan: LogicalPlan): Seq[Expression] = {
val exprs = plan.expressions
val invalidExpressions = exprs.flatMap { root =>
root.collect {
case e: WindowExpression
if !plan.isInstanceOf[Window] => e
case e: AggregateExpression
if !(plan.isInstanceOf[Aggregate] ||
plan.isInstanceOf[Window] ||
plan.isInstanceOf[CollectMetrics] ||
onlyInLateralSubquery(plan)) => e
case e: Generator
if !(plan.isInstanceOf[Generate] ||
plan.isInstanceOf[BaseEvalPythonUDTF]) => e
}
}
invalidExpressions
}
```
It doesn't make sense to map every single operator to its operation. I would still keep it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3552996247
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
I presume the goal of this PR is to improve an error message. If an error message improvement needs a follow up PR then this sounds more like a check-box PR to me.
We should fix others that expose non-user facing gibberish as well. THAT coudl be a follow up. RIght now let's stop the bleed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3544584684
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/resolver/Resolver.scala:
##########
@@ -871,10 +871,13 @@ class Resolver(
summary = operator.origin.context.summary()
)
- private def throwUnsupportedExprForOperator(invalidExpressions: Seq[Expression]): Nothing = {
+ private def throwUnsupportedExprForOperator(
+ operator: LogicalPlan,
+ invalidExpressions: Seq[Expression]): Nothing = {
throw new AnalysisException(
errorClass = "UNSUPPORTED_EXPR_FOR_OPERATOR",
messageParameters = Map(
+ "operator" -> operator.nodeName,
Review Comment:
These are internal names. When you look at the test results some of them are hard to map back to teh external name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor commented on PR #57081:
URL: https://github.com/apache/spark/pull/57081#issuecomment-4975247760
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/e6d88df734b0e4d1b003edd48663e9f455a161ab
- merged into branch-4.x https://github.com/apache/spark/commit/82a22bbb87652d97e83a9a16eae32572db78301c
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3544609759
##########
sql/core/src/test/resources/sql-tests/analyzer-results/postgreSQL/window_part3.sql.out:
##########
@@ -342,7 +343,8 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException
"errorClass" : "UNSUPPORTED_EXPR_FOR_OPERATOR",
"sqlState" : "42K0E",
"messageParameters" : {
- "invalidExprSqls" : "\"RANK() OVER (ORDER BY 1 ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW)\""
+ "invalidExprSqls" : "\"RANK() OVER (ORDER BY 1 ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW)\"",
+ "operator" : "Aggregate"
Review Comment:
```suggestion
"operator" : "GROUP BY"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3545334954
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
I partially agree. Although it would be better to have operations instead of operators but it's already like that all over the place in Spark:
- `SELECT * FROM VALUES (1, 10, 20) AS t(id, a, b) UNPIVOT (val FOR name IN (a, b)) ORDER BY t.a` throw `[MISSING_ATTRIBUTES.RESOLVED_ATTRIBUTE_MISSING_FROM_INPUT] Resolved attribute(s) "a" missing from "id", "name", "val" in operator Sort`
- `SELECT * FROM VALUES(1) GROUP BY *` throw `[INVALID_USAGE_OF_STAR_OR_REGEX] Invalid usage of '*' in Aggregate`
- etc
Also it would require more work since we would have to map operators to operations which seem like a unnecessary overhead since we already have same stuff in other exceptions. I would leave it as it is for now if you agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "dtenedor (via GitHub)" <gi...@apache.org>.
dtenedor closed pull request #57081: [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message
URL: https://github.com/apache/spark/pull/57081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3571714184
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
@srielau Should we proceed with merging this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3544567443
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -8142,8 +8142,8 @@
},
"UNSUPPORTED_EXPR_FOR_OPERATOR" : {
"message" : [
- "A query operator contains one or more unsupported expressions.",
- "Consider to rewrite it to avoid window functions, aggregate functions, and generator functions in the WHERE clause.",
+ "The query operator <operator> contains one or more unsupported expressions.",
Review Comment:
I wonder whether operator is the best term. Here it seems it applies to a mix of different scenarios. Maybe just diluting it to "operation" works better. More generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58001] [SQL] Improve `UNSUPPORTED_EXPR_FOR_OPERATOR` error message [spark]
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #57081:
URL: https://github.com/apache/spark/pull/57081#discussion_r3544597479
##########
sql/core/src/test/resources/sql-tests/analyzer-results/postgreSQL/window_part3.sql.out:
##########
@@ -322,7 +322,8 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException
"errorClass" : "UNSUPPORTED_EXPR_FOR_OPERATOR",
"sqlState" : "42K0E",
"messageParameters" : {
- "invalidExprSqls" : "\"row_number() OVER (ORDER BY salary ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW)\""
+ "invalidExprSqls" : "\"row_number() OVER (ORDER BY salary ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW)\"",
+ "operator" : "Join"
Review Comment:
```suggestion
"operator" : "ON"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org