You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/19 00:21:02 UTC

[GitHub] [airflow] ecerulm opened a new pull request #14308: fix: add dags volumeMount when gitSync.enabled

ecerulm opened a new pull request #14308:
URL: https://github.com/apache/airflow/pull/14308


   The `dags` volumeMount must be included when `.dags.gitSync.enabled` otherwise the `git-sync` container will copy
   the dag file to the `dags` volume but the scheduler will not see them. 
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed pull request #14308: fix: add dags volumeMount when gitSync.enabled

Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #14308:
URL: https://github.com/apache/airflow/pull/14308


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #14308: fix: add dags volumeMount when gitSync.enabled

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14308:
URL: https://github.com/apache/airflow/pull/14308#discussion_r578839507



##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -160,7 +160,7 @@ spec:
               subPath: airflow_local_settings.py
               readOnly: true
 {{- end }}
-{{- if .Values.dags.persistence.enabled }}
+{{- if or .Values.dags.gitSync.enabled .Values.dags.persistence.enabled }}

Review comment:
       Can you please add a test in https://github.com/apache/airflow/blob/master/chart/tests/test_git_sync_scheduler.py




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #14308: fix: add dags volumeMount when gitSync.enabled

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14308:
URL: https://github.com/apache/airflow/pull/14308#issuecomment-781741506


   Looks like there was already a PR to fix it: https://github.com/apache/airflow/pull/14203 from 7 days ago so merged that one instead but thank you very much for reporting and creating this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #14308: fix: add dags volumeMount when gitSync.enabled

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14308:
URL: https://github.com/apache/airflow/pull/14308#discussion_r578839507



##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -160,7 +160,7 @@ spec:
               subPath: airflow_local_settings.py
               readOnly: true
 {{- end }}
-{{- if .Values.dags.persistence.enabled }}
+{{- if or .Values.dags.gitSync.enabled .Values.dags.persistence.enabled }}

Review comment:
       Can you please add a test in https://github.com/apache/airflow/blob/master/chart/tests/test_git_sync_scheduler.py




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org