You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/08/30 18:16:52 UTC
[jira] [Commented] (TS-2163) Remove WDA_BILLING, ACC_ALARMS etc.
code and definitions
[ https://issues.apache.org/jira/browse/TS-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754844#comment-13754844 ]
ASF subversion and git services commented on TS-2163:
-----------------------------------------------------
Commit dbbc5a27462e6e1c9611e48619284a97d2f1df68 in branch refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=dbbc5a2 ]
TS-2163 Remove obsolete WDA and ACC alarms feature
This was done for an Inktomi specific customer plugin, and no longer applies
to the project. If we later decide it necessary, we should add new APIs which
let plugins register new alarms with the system for appropriate handling.
Reading the code, it looks to me like the Alarms code was intended to be
replaced as well, so this could be part of a code refactoring/replacement.
> Remove WDA_BILLING, ACC_ALARMS etc. code and definitions
> --------------------------------------------------------
>
> Key: TS-2163
> URL: https://issues.apache.org/jira/browse/TS-2163
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 4.1.0
>
>
> These defines and API was designed for a specific Inktomi customer, which asked for their own set of alarms for their plugin. This is useless IMO, and we should remove it. IF long term we want extensible alarm codes, a different solution should be put in place (one where plugins can register alarms and alarms definitions).
> Please voice your objections to this if you feel that these should stay:
> {code}
> -#define REC_ALARM_WDA_BILLING_CONNECTION_DIED 100
> -#define REC_ALARM_WDA_BILLING_CORRUPTED_DATA 101
> -#define REC_ALARM_WDA_XF_ENGINE_DOWN 102
> -#define REC_ALARM_WDA_RADIUS_CORRUPTED_PACKETS 103
> -
> -#define REC_ALARM_ACC_ALARMS_START 200
> -#define REC_ALARM_ACC_ALARMS_END 299
> {code}
> and from ts/experimental.h (oxygen was the Inktomi customer I think):
> {code}
> - typedef enum
> - {
> - TS_SIGNAL_WDA_BILLING_CONNECTION_DIED = 100,
> - TS_SIGNAL_WDA_BILLING_CORRUPTED_DATA = 101,
> - TS_SIGNAL_WDA_XF_ENGINE_DOWN = 102,
> - TS_SIGNAL_WDA_RADIUS_CORRUPTED_PACKETS = 103
> - } TSAlarmType;
> -
> - /* ===== Alarm ===== */
> - /****************************************************************************
> - * ??
> - * contact: OXYGEN
> - ****************************************************************************/
> - tsapi void TSSignalWarning(TSAlarmType code, char *msg);
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira