You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/10 10:33:40 UTC

[GitHub] [airflow] potiuk commented on pull request #10218: Implement Google BigQuery Table Partition Sensor

potiuk commented on pull request #10218:
URL: https://github.com/apache/airflow/pull/10218#issuecomment-671280073


   Looks good. I think it's ok to keep separate example dag. One thing do - it would be great to extract parts of it to the HowTo Guide (there are those comments that are used to include some parts of the example: https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/example_dags/example_dataproc.py#L45
   
   Plus some static checks are failing :(
   
   Heartily recommend pre-commit installation https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#pre-commit-hooks - it saves a TON of time for back/forth with CI :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org