You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Naganarasimha G R (JIRA)" <ji...@apache.org> on 2017/07/01 06:30:02 UTC

[jira] [Comment Edited] (YARN-2919) Potential race between renew and cancel in DelegationTokenRenwer

    [ https://issues.apache.org/jira/browse/YARN-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071037#comment-16071037 ] 

Naganarasimha G R edited comment on YARN-2919 at 7/1/17 6:29 AM:
-----------------------------------------------------------------

Thanks [~djp] for taking a look at the patch and sorry for the delayed reply.
I checked multiple times these were my findings :
# {{TestRMRestart.testRMRestartWaitForPreviousAMToFinish}} fails always with or without patch even after YARN-5416. I have raise YARN-6759 for it.
# {{TestDelegationTokenRenewer}} is same as YARN-5816 tested multiple times in the local setup it never fails and had seen some one complaining about the failure but was not able to find out the jira. I have raise YARN- for it 
# {{TestRaceWhenRelogin.test}} also passes in my local setup and failure does not seem to be related to the patch.

Also i tested {{org.apache.hadoop.fs.TestDelegationTokenRenewer}} and all the test cases passes there too.

Have uploaded the patch with reworking on your comment. Please check if the log message is fine or you were expecting some thing else 


was (Author: naganarasimha):
Thanks [~djp] for taking a look at the patch and sorry for the delayed reply.
I checked multiple times these were my findings :
# {{TestRMRestart.testRMRestartWaitForPreviousAMToFinish}} fails always with or without patch even after YARN-5416. I have raise YARN- for it.
# {{TestDelegationTokenRenewer}} is same as YARN-5816 tested multiple times in the local setup it never fails and had seen some one complaining about the failure but was not able to find out the jira. I have raise YARN- for it 
# {{TestRaceWhenRelogin.test}} also passes in my local setup and failure does not seem to be related to the patch.

Have uploaded the patch with reworking on your comment. Please check if the log message is fine or you were expecting some thing else 

> Potential race between renew and cancel in DelegationTokenRenwer 
> -----------------------------------------------------------------
>
>                 Key: YARN-2919
>                 URL: https://issues.apache.org/jira/browse/YARN-2919
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2919.002.patch, YARN-2919.003.patch, YARN-2919.004.patch, YARN-2919.005.patch, YARN-2919.20141209-1.patch
>
>
> YARN-2874 fixes a deadlock in DelegationTokenRenewer, but there is still a race because of which a renewal in flight isn't interrupted by a cancel. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org