[jira] [Commented] (ORC-281) Fix compiler warnings from clang 5.0

["Owen O'Malley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297075#comment-16297075 ] 

Owen O'Malley commented on ORC-281:
-----------------------------------

Ok, there turned out to be a lot of new warnings with clang 5.0:
* require override on destructors
* use nullptr instead of 0 (or NULL)

So my patch fixes all of those. It also adds a new docker file ubuntu16-clang5 that installs clang 5.0 and uses it for the build.

However, after fixing all of the warnings, one of the unit tests fails when built with optimization and passes when built with debug. I assume that it is a compiler optimization bug. Therefore I changed our travis-ci to use clang 4.0 again. I also did not add the new docker file to the docker/run-all.sh script.

> Fix compiler warnings from clang 5.0
> ------------------------------------
>
>                 Key: ORC-281
>                 URL: https://issues.apache.org/jira/browse/ORC-281
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> We're currently getting:
> {code}
> [ 43%] Building CXX object c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o
> In file included from /home/travis/build/apache/orc/c++/src/io/InputStream.cc:20:
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:75:13: error: '~SeekableArrayInputStream' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
>     virtual ~SeekableArrayInputStream();
>             ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:53:13: note: overridden virtual function is here
>     virtual ~SeekableInputStream();
>             ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:104:13: error: '~SeekableFileInputStream' overrides a destructor but is not marked 'override' [-Werror,-Winconsistent-missing-destructor-override]
>     virtual ~SeekableFileInputStream();
>             ^
> /home/travis/build/apache/orc/c++/src/io/InputStream.hh:53:13: note: overridden virtual function is here
>     virtual ~SeekableInputStream();
>             ^
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)