You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by shukitchan <gi...@git.apache.org> on 2016/10/11 15:42:54 UTC
[GitHub] trafficserver pull request #1089: TS-4592: Add support for process ID and tx...
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/1089
TS-4592: Add support for process ID and txn ID in ts_lua
@zwoop please take a look and review. Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shukitchan/trafficserver ts4592
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1089.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1089
----
commit 0cd3ea3d368430adb5314422d5a687d4e5a4e167
Author: Kit Chan <ki...@apache.org>
Date: 2016-10-11T15:41:08Z
TS-4592: Add support for process ID and txn ID in ts_lua
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1089
@zwoop it should be good now. Please take a look.
And of course I will squash before merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/850/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/977/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/992/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/869/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1089: TS-4592: Add support for process ID and tx...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1089#discussion_r83085975
--- Diff: plugins/experimental/ts_lua/ts_lua_misc.c ---
@@ -66,6 +71,20 @@ ts_lua_inject_misc_variables(lua_State *L)
}
static int
+ts_lua_get_process_id(lua_State *L)
+{
+ const char *s;
+ TSUuid process = TSProcessUuidGet();
+ if (process) {
+ s = TSUuidStringGet(process);
--- End diff --
None of these calls fail. IMHO it is fine to ``lua_error`` or ``ink_release_assert`` rather than attempting error handling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/870/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1089
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1089
Maybe you have to rebase this from master, to get the clang-format fixes that were done yesterday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/1089
@zwoop & @jpeach , it is updated according to the comment. Please review again. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/958/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1089: TS-4592: Add support for process ID and tx...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/1089
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1089: TS-4592: Add support for process ID and tx...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1089#discussion_r83085682
--- Diff: doc/admin-guide/plugins/ts_lua.en.rst ---
@@ -131,6 +131,22 @@ is always available within lua script. This package can be introduced into Lua l
`TOP <#ts-lua-plugin>`_
+ts.process_id
+-------------
+**syntax:** *val = ts.process_id()*
--- End diff --
Suggest you call this ``uuid`` rather than ``id`` since the latter implies numeric.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/884/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1089: TS-4592: Add support for process ID and tx...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1089#discussion_r83085542
--- Diff: doc/admin-guide/plugins/ts_lua.en.rst ---
@@ -131,6 +131,22 @@ is always available within lua script. This package can be introduced into Lua l
`TOP <#ts-lua-plugin>`_
+ts.process_id
+-------------
+**syntax:** *val = ts.process_id()*
--- End diff --
Why doesn't this match ``ts.http.id()`` (ie. ``ts.process.id()``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1089: TS-4592: Add support for process ID and txn ID in...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1089
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/978/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---