You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/10/05 21:06:12 UTC
Review Request 52571: GEODE-1570: upgrade spring libraries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
Repository: geode
Description
-------
GEODE-1570: upgrade spring libraries and related libraries
* upgrade the spring related libraries
* rafactored the tests to get rid of redundant code
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
Diff: https://reviews.apache.org/r/52571/diff/
Testing
-------
precheckin running.
Thanks,
Jinmei Liao
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
You must be looking at some wrong patch, or the patch did not apply
correctly. The tests are passing:
http://test-results-jinmei-1570-2.s3-website-us-west-2.amazonaws.com/test
http://test-results-jinmei-1570-2.s3-website-us-west-2.
amazonaws.com/flakyTest/
On Wed, Oct 5, 2016 at 3:33 PM, Jared Stewart <js...@pivotal.io> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
>
> I also have a few unit tests failing from this patch:
>
> org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest > testInitFile_TwoBadCommands FAILED
> java.lang.AssertionError: Log records written expected:<4> but was:<3>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest.testInitFile_TwoBadCommands(GfshInitFileJUnitTest.java:402)
>
> org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest > testInitFile_OneBadCommand FAILED
> java.lang.AssertionError: Log records written expected:<4> but was:<3>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest.testInitFile_OneBadCommand(GfshInitFileJUnitTest.java:371)
>
> org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest > testInitFile_BadAndGoodCommands FAILED
> java.lang.AssertionError: Log records written expected:<4> but was:<3>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest.testInitFile_BadAndGoodCommands(GfshInitFileJUnitTest.java:434)
>
>
> - Jared Stewart
>
> On October 5th, 2016, 9:06 p.m. UTC, Jinmei Liao wrote:
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk
> Lund, and Dan Smith.
> By Jinmei Liao.
>
> *Updated Oct. 5, 2016, 9:06 p.m.*
> *Repository: * geode
> Description
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> - upgrade the spring related libraries
> - rafactored the tests to get rid of redundant code
>
> Testing
>
> precheckin running.
>
> Diffs
>
> - geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java
> (0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093)
> - geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java
> (a9d90ed5489a9ab6b936674369b5e5a870651738)
> - geode-assembly/src/test/resources/expected_jars.txt (
> 939464a92a3f1846b8fb9b9d1faa75dad5133289)
> - geode-core/build.gradle (3cbdfbea41a7f34b237394e92a463919d0109f47)
> - geode-core/src/test/java/org/apache/geode/management/
> internal/cli/shell/GfshInitFileJUnitTest.java (
> 9e7b7bf17920a9dc42905bab4ccb4590ca20223a)
> - geode-core/src/test/java/org/apache/geode/security/
> AbstractSecureServerDUnitTest.java (435b426627deea6c67ecd79bc014ec
> 97774e2ebf)
> - geode-pulse/src/main/java/org/apache/geode/tools/pulse/
> internal/security/GemFireAuthentication.java (
> 425f5a5aa76c8219678164ebbb012d1361519bc7)
> - geode-pulse/src/main/java/org/apache/geode/tools/pulse/
> internal/security/GemFireAuthenticationProvider.java (
> f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4)
> - geode-pulse/src/main/java/org/apache/geode/tools/pulse/
> internal/service/MemberGatewayHubService.java (
> 51abb3f39902938149fb67a416f571ba31b75d77)
> - geode-pulse/src/main/webapp/Login.html (
> f22490f4df098c0b12dadeefcb1855a51efc6281)
> - geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml (
> cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe)
> - geode-pulse/src/main/webapp/WEB-INF/spring-security.xml (
> 924dd50f579a6e4e306b94f4a7fd88e87f978add)
> - geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java
> (a77e0cacdcde69f47fbd13c588601072c432ee0d)
> - geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java
> (a4f14f89ea739e7390565d652fc5affa6e1326c6)
> - geode-web-api/src/main/java/org/apache/geode/rest/
> internal/web/util/JSONUtils.java (ccf3b9d9f0d0aebadbf628ef6bdcef
> 1084e81b5d)
> - geode-web-api/src/main/java/org/apache/geode/rest/
> internal/web/util/JsonWriter.java (1fcffbd4eee26fee890f1587947276
> 47145a1914)
> - geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml (
> c75d975c4313f953cce5ac7f5a8cd8a228718a8c)
> - geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml (
> 3b1d1658ea2414190852cc1268fd9f1beccf4d20)
> - gradle/dependency-resolution.gradle (91d1755848ba9ce23fab3190555c29
> 06bcffd97b)
> - gradle/dependency-versions.properties (65fd2ee1d46156781ee70165aac578
> c5ca14490a)
>
> View Diff <https://reviews.apache.org/r/52571/diff/>
>
--
Cheers
Jinmei
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151584
-----------------------------------------------------------
I also have a few unit tests failing from this patch:
```
org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest > testInitFile_TwoBadCommands FAILED
java.lang.AssertionError: Log records written expected:<4> but was:<3>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest.testInitFile_TwoBadCommands(GfshInitFileJUnitTest.java:402)
org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest > testInitFile_OneBadCommand FAILED
java.lang.AssertionError: Log records written expected:<4> but was:<3>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest.testInitFile_OneBadCommand(GfshInitFileJUnitTest.java:371)
org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest > testInitFile_BadAndGoodCommands FAILED
java.lang.AssertionError: Log records written expected:<4> but was:<3>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.apache.geode.management.internal.cli.shell.GfshInitFileJUnitTest.testInitFile_BadAndGoodCommands(GfshInitFileJUnitTest.java:434)
```
- Jared Stewart
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151712
-----------------------------------------------------------
NOTICE changes look good!
- Anthony Baker
On Oct. 6, 2016, 6:34 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2016, 6:34 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
> * update the NOTICE files
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/NOTICE 1924007f6c4822f59e0a830acf4e2b01f67170ef
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/META-INF/NOTICE 40f9fc875d6bc53d073061495738f636ad60433c
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/build.gradle 3ea652b65456168689250f35be553c2eeda193d9
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/META-INF/NOTICE 2f4da6e85a2daa75e136bbc80e62768193f65db9
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/META-INF/NOTICE dd46891056a99365494ac212fec8ef8b3dd0a201
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151724
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Oct. 6, 2016, 6:34 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2016, 6:34 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
> * update the NOTICE files
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/NOTICE 1924007f6c4822f59e0a830acf4e2b01f67170ef
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/META-INF/NOTICE 40f9fc875d6bc53d073061495738f636ad60433c
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/build.gradle 3ea652b65456168689250f35be553c2eeda193d9
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/META-INF/NOTICE 2f4da6e85a2daa75e136bbc80e62768193f65db9
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/META-INF/NOTICE dd46891056a99365494ac212fec8ef8b3dd0a201
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/
-----------------------------------------------------------
(Updated Oct. 6, 2016, 6:34 p.m.)
Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
Repository: geode
Description
-------
GEODE-1570: upgrade spring libraries and related libraries
* upgrade the spring related libraries
* rafactored the tests to get rid of redundant code
* update the NOTICE files
Diffs (updated)
-----
geode-assembly/src/main/dist/NOTICE 1924007f6c4822f59e0a830acf4e2b01f67170ef
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
geode-pulse/src/main/webapp/META-INF/NOTICE 40f9fc875d6bc53d073061495738f636ad60433c
geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
geode-web-api/build.gradle 3ea652b65456168689250f35be553c2eeda193d9
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
geode-web-api/src/main/webapp/META-INF/NOTICE 2f4da6e85a2daa75e136bbc80e62768193f65db9
geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
geode-web/src/main/webapp/META-INF/NOTICE dd46891056a99365494ac212fec8ef8b3dd0a201
geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
Diff: https://reviews.apache.org/r/52571/diff/
Testing
-------
precheckin running.
Thanks,
Jinmei Liao
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/
-----------------------------------------------------------
(Updated Oct. 6, 2016, 6:31 p.m.)
Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
Repository: geode
Description (updated)
-------
GEODE-1570: upgrade spring libraries and related libraries
* upgrade the spring related libraries
* rafactored the tests to get rid of redundant code
* update the NOTICE files
Diffs (updated)
-----
geode-assembly/src/main/dist/NOTICE 1924007f6c4822f59e0a830acf4e2b01f67170ef
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java df146a6b8a3c539d50f036a5adaea5f486e8a7d6
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityEndpointsDUnitTest.java PRE-CREATION
geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
geode-core/build.gradle b2e5a4efd9114db0b9c49c8541cf1cc72c2644fe
geode-core/src/main/java/org/apache/geode/management/internal/JettyHelper.java 089dbacb056da84d6d6ceb36dad6f09b9ce73890
geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
geode-pulse/src/main/webapp/META-INF/NOTICE 40f9fc875d6bc53d073061495738f636ad60433c
geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 3756df7d082d6b2d084c6a4b4446a6a9384d558c
geode-pulse/src/test/java/org/apache/geode/tools/pulse/testbed/driver/PulseUITest.java a2365a2dfa3e221fa50664c3f8d96fae2bd93c86
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java 5024250f8ff3867e0f527d7ef5fbbd501e2d64ee
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
geode-web-api/build.gradle 9e93bb92829acff56f39fdfccacdfae90e21ceeb
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseController.java e94998b5ea358acf75162aa402170c6dbf298951
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java a4f58b97fe5b54809f7d33684fa52b0908fb216f
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/CommonCrudController.java b3128848a13325d6aae791a119665dbdb2e281d1
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java c31292bbf2928956592b3040be5cbc7dae9677f7
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/PdxBasedCrudController.java dd7731670b4e6310aa2eb474ef0057bb0f55e8d5
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/QueryAccessController.java 4f059a4283ac6dd72cc0f5207aaae37c6d2b872a
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthentication.java PRE-CREATION
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthenticationProvider.java PRE-CREATION
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/GeodeAuthority.java PRE-CREATION
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityConfiguration.java PRE-CREATION
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
geode-web-api/src/main/webapp/META-INF/NOTICE 2f4da6e85a2daa75e136bbc80e62768193f65db9
geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c24e74a96c4c132e3b62ce4789aa3cff441cc977
geode-web-api/src/main/webapp/WEB-INF/web.xml 956294a5a799b2b86acd4da90b510239cecdba5e
geode-web/src/main/webapp/META-INF/NOTICE dd46891056a99365494ac212fec8ef8b3dd0a201
geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
gradle.properties 1882b7b3fd55a17db962aa6d08179e572c72fffc
gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
gradle/dependency-versions.properties 0abe690d2484258edded988abbfac24e560fbff8
Diff: https://reviews.apache.org/r/52571/diff/
Testing
-------
precheckin running.
Thanks,
Jinmei Liao
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151676
-----------------------------------------------------------
My previous issues were due to applying this patch to DEVELOP rather than release/1.0.0-incubating.
- Jared Stewart
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151558
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Duling
On Oct. 5, 2016, 2:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 2:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jared Stewart <js...@pivotal.io>.
> On Oct. 5, 2016, 9:47 p.m., Jared Stewart wrote:
> > I also get compilation errors in PulseAppListener and ExceptionHandlingAdvice when I apply this patch, even after refreshing gradle.
>
> Jinmei Liao wrote:
> Hnnn, do a clean and refresh. I am not getting the errors.
No luck. Have you tried doing a clean and then running "gradle uiTest"?
I verified in gradle that this is a problem caused by the removal of the "force" block in dependency-resolution.gradle.
Before this patch:
```
~/projects/gemfire/open (develop) $ gradle :geode-pulse:dI --dependency spring-web
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar UP-TO-DATE
:buildSrc:assemble UP-TO-DATE
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build UP-TO-DATE
:geode-pulse:dependencyInsight
org.springframework:spring-web:4.2.4.RELEASE (forced)
org.springframework:spring-web:3.0.7.RELEASE -> 4.2.4.RELEASE
--- org.springframework.security:spring-security-web:3.1.7.RELEASE
--- compile
BUILD SUCCESSFUL
```
After this patch:
```
~/projects/gemfire/open (develop) $ gradle :geode-pulse:dI --dependency spring-web
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar UP-TO-DATE
:buildSrc:assemble UP-TO-DATE
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build UP-TO-DATE
:geode-pulse:dependencyInsight
org.springframework:spring-web:3.0.7.RELEASE
--- org.springframework.security:spring-security-web:3.1.7.RELEASE
--- compile
BUILD SUCCESSFUL
```
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151569
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
> On Oct. 5, 2016, 9:47 p.m., Jared Stewart wrote:
> > I also get compilation errors in PulseAppListener and ExceptionHandlingAdvice when I apply this patch, even after refreshing gradle.
Hnnn, do a clean and refresh. I am not getting the errors.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151569
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151569
-----------------------------------------------------------
I also get compilation errors in PulseAppListener and ExceptionHandlingAdvice when I apply this patch, even after refreshing gradle.
- Jared Stewart
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Kevin Duling <kd...@pivotal.io>.
> On Oct. 5, 2016, 2:18 p.m., Jared Stewart wrote:
> > Aren't the (OutputStream) casts in JSONUtils.java redundant since outputStream here is already an instance of HeapDataOutputStream which extends OutputStream?
> >
> > Also, I believe our schemaLocations in *-servlet.xml ought to refer to versioned URLs so that we do not break when a new Spring version is released before we have updated to that version.
When I was trying to do this ticket, I ran in to the necessity of having to cast because the compiler objected, saying there was no matching method that would accept it -- even though it clearly appeared there was. By casting, it resolved it. I'm sure Jinmei ran in to the same issue when she worked on the upgrade.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151560
-----------------------------------------------------------
On Oct. 5, 2016, 2:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 2:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
> On Oct. 5, 2016, 9:18 p.m., Jared Stewart wrote:
> > Aren't the (OutputStream) casts in JSONUtils.java redundant since outputStream here is already an instance of HeapDataOutputStream which extends OutputStream?
> >
> > Also, I believe our schemaLocations in *-servlet.xml ought to refer to versioned URLs so that we do not break when a new Spring version is released before we have updated to that version.
>
> Kevin Duling wrote:
> When I was trying to do this ticket, I ran in to the necessity of having to cast because the compiler objected, saying there was no matching method that would accept it -- even though it clearly appeared there was. By casting, it resolved it. I'm sure Jinmei ran in to the same issue when she worked on the upgrade.
If I remeber correctly, if I don't cast, it complains about some method ambiguity.
And for schemeLocations, It is recommended to use the "versionless" XSDs, because they're mapped to the current version of the framework you're using in your application.
http://stackoverflow.com/questions/20894695/spring-configuration-xml-schema-with-or-without-version
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151560
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jared Stewart <js...@pivotal.io>.
> On Oct. 5, 2016, 9:18 p.m., Jared Stewart wrote:
> > Aren't the (OutputStream) casts in JSONUtils.java redundant since outputStream here is already an instance of HeapDataOutputStream which extends OutputStream?
> >
> > Also, I believe our schemaLocations in *-servlet.xml ought to refer to versioned URLs so that we do not break when a new Spring version is released before we have updated to that version.
>
> Kevin Duling wrote:
> When I was trying to do this ticket, I ran in to the necessity of having to cast because the compiler objected, saying there was no matching method that would accept it -- even though it clearly appeared there was. By casting, it resolved it. I'm sure Jinmei ran in to the same issue when she worked on the upgrade.
>
> Jinmei Liao wrote:
> If I remeber correctly, if I don't cast, it complains about some method ambiguity.
>
> And for schemeLocations, It is recommended to use the "versionless" XSDs, because they're mapped to the current version of the framework you're using in your application.
> http://stackoverflow.com/questions/20894695/spring-configuration-xml-schema-with-or-without-version
Cool, thanks for the info about the "versionless" XSDs!
- Jared
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151560
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151560
-----------------------------------------------------------
Aren't the (OutputStream) casts in JSONUtils.java redundant since outputStream here is already an instance of HeapDataOutputStream which extends OutputStream?
Also, I believe our schemaLocations in *-servlet.xml ought to refer to versioned URLs so that we do not break when a new Spring version is released before we have updated to that version.
- Jared Stewart
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
> On Oct. 5, 2016, 9:24 p.m., Anthony Baker wrote:
> > geode-assembly/src/test/resources/expected_jars.txt, line 20
> > <https://reviews.apache.org/r/52571/diff/1/?file=1523374#file1523374line20>
> >
> > Does this jar need to be on the geode/gfsh-dependencies.jar classpath? If so, add to the list in geode-assembly/build.gradle.
jackson-module-paranamer is pulled in by the latest version of jackson-module-scala_2.10. Looks like geode-web-api is using scala_2.10, but it's not used by gfsh.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151559
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Anthony Baker <ab...@apache.org>.
> On Oct. 5, 2016, 9:24 p.m., Anthony Baker wrote:
> > geode-core/build.gradle, line 90
> > <https://reviews.apache.org/r/52571/diff/1/?file=1523375#file1523375line90>
> >
> > We just eliminated spring-core from the classpath of geode-core...what code needs this jar?
>
> Jinmei Liao wrote:
> spring-core is still pulled in geode-core by sping-shell. It's still used by GfshMethodTarget.
Ok, makes sense. I think we should set the optional flag so that client apps using the geode-core dependency won't drag in a ton of unnecessary deps.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151559
-----------------------------------------------------------
On Oct. 6, 2016, 6:34 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2016, 6:34 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
> * update the NOTICE files
>
>
> Diffs
> -----
>
> geode-assembly/src/main/dist/NOTICE 1924007f6c4822f59e0a830acf4e2b01f67170ef
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/META-INF/NOTICE 40f9fc875d6bc53d073061495738f636ad60433c
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/build.gradle 3ea652b65456168689250f35be553c2eeda193d9
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/META-INF/NOTICE 2f4da6e85a2daa75e136bbc80e62768193f65db9
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/META-INF/NOTICE dd46891056a99365494ac212fec8ef8b3dd0a201
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
> On Oct. 5, 2016, 9:24 p.m., Anthony Baker wrote:
> > geode-core/build.gradle, line 90
> > <https://reviews.apache.org/r/52571/diff/1/?file=1523375#file1523375line90>
> >
> > We just eliminated spring-core from the classpath of geode-core...what code needs this jar?
spring-core is still pulled in geode-core by sping-shell. It's still used by GfshMethodTarget.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151559
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Jinmei Liao <ji...@pivotal.io>.
> On Oct. 5, 2016, 9:24 p.m., Anthony Baker wrote:
> > gradle/dependency-resolution.gradle, line 18
> > <https://reviews.apache.org/r/52571/diff/1/?file=1523390#file1523390line18>
> >
> > What's different that allows us to remove this code?
by upgrading the libraries, we don't need these force statement anymore. It will just pull in the needed versions.
- Jinmei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151559
-----------------------------------------------------------
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>
Re: Review Request 52571: GEODE-1570: upgrade spring libraries
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52571/#review151559
-----------------------------------------------------------
geode-assembly/src/test/resources/expected_jars.txt (line 20)
<https://reviews.apache.org/r/52571/#comment220006>
Does this jar need to be on the geode/gfsh-dependencies.jar classpath? If so, add to the list in geode-assembly/build.gradle.
geode-core/build.gradle (line 90)
<https://reviews.apache.org/r/52571/#comment220007>
We just eliminated spring-core from the classpath of geode-core...what code needs this jar?
gradle/dependency-resolution.gradle
<https://reviews.apache.org/r/52571/#comment220008>
What's different that allows us to remove this code?
There are a few LICENSE / NOTICE files that need to be updated with the new versions:
~/code/incubator-geode (develop)$ find . -name 'LICENSE' -o -name 'NOTICE'
./geode-assembly/src/main/dist/LICENSE
./geode-assembly/src/main/dist/NOTICE
./geode-pulse/src/main/webapp/META-INF/NOTICE
./geode-web/src/main/webapp/META-INF/NOTICE
./geode-web-api/src/main/webapp/META-INF/NOTICE
./LICENSE
./NOTICE
- Anthony Baker
On Oct. 5, 2016, 9:06 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52571/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:06 p.m.)
>
>
> Review request for geode, Anthony Baker, Jared Stewart, Kevin Duling, Kirk Lund, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-1570: upgrade spring libraries and related libraries
>
> * upgrade the spring related libraries
> * rafactored the tests to get rid of redundant code
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestInterfaceJUnitTest.java 0d9351889b54b3ffdd6cba4e7ade4ae5e5a17093
> geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityDUnitTest.java a9d90ed5489a9ab6b936674369b5e5a870651738
> geode-assembly/src/test/resources/expected_jars.txt 939464a92a3f1846b8fb9b9d1faa75dad5133289
> geode-core/build.gradle 3cbdfbea41a7f34b237394e92a463919d0109f47
> geode-core/src/test/java/org/apache/geode/management/internal/cli/shell/GfshInitFileJUnitTest.java 9e7b7bf17920a9dc42905bab4ccb4590ca20223a
> geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java 435b426627deea6c67ecd79bc014ec97774e2ebf
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthentication.java 425f5a5aa76c8219678164ebbb012d1361519bc7
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/security/GemFireAuthenticationProvider.java f4575ccf5c894e2cbaaebc51ffc4d7f56fce68c4
> geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/service/MemberGatewayHubService.java 51abb3f39902938149fb67a416f571ba31b75d77
> geode-pulse/src/main/webapp/Login.html f22490f4df098c0b12dadeefcb1855a51efc6281
> geode-pulse/src/main/webapp/WEB-INF/mvc-dispatcher-servlet.xml cb7181d3279e2c2dfc86ddc201fa6dc002eb55fe
> geode-pulse/src/main/webapp/WEB-INF/spring-security.xml 924dd50f579a6e4e306b94f4a7fd88e87f978add
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAuthTest.java a77e0cacdcde69f47fbd13c588601072c432ee0d
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAutomatedTest.java a4f14f89ea739e7390565d652fc5affa6e1326c6
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JSONUtils.java ccf3b9d9f0d0aebadbf628ef6bdcef1084e81b5d
> geode-web-api/src/main/java/org/apache/geode/rest/internal/web/util/JsonWriter.java 1fcffbd4eee26fee890f158794727647145a1914
> geode-web-api/src/main/webapp/WEB-INF/geode-servlet.xml c75d975c4313f953cce5ac7f5a8cd8a228718a8c
> geode-web/src/main/webapp/WEB-INF/geode-mgmt-servlet.xml 3b1d1658ea2414190852cc1268fd9f1beccf4d20
> gradle/dependency-resolution.gradle 91d1755848ba9ce23fab3190555c2906bcffd97b
> gradle/dependency-versions.properties 65fd2ee1d46156781ee70165aac578c5ca14490a
>
> Diff: https://reviews.apache.org/r/52571/diff/
>
>
> Testing
> -------
>
> precheckin running.
>
>
> Thanks,
>
> Jinmei Liao
>
>