You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/11 02:05:47 UTC

[james-project] 04/09: [REFACTORING] MultiLineHandler class is not used

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 77989aa85fb9f9902c2cd5583d6ec2c8869bda4f
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Fri Nov 8 10:40:36 2019 +0700

    [REFACTORING] MultiLineHandler class is not used
---
 .../protocols/api/handler/MultiLineHandler.java    | 67 ----------------------
 1 file changed, 67 deletions(-)

diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/handler/MultiLineHandler.java b/protocols/api/src/main/java/org/apache/james/protocols/api/handler/MultiLineHandler.java
deleted file mode 100644
index 5590df3..0000000
--- a/protocols/api/src/main/java/org/apache/james/protocols/api/handler/MultiLineHandler.java
+++ /dev/null
@@ -1,67 +0,0 @@
-/****************************************************************
- * Licensed to the Apache Software Foundation (ASF) under one   *
- * or more contributor license agreements.  See the NOTICE file *
- * distributed with this work for additional information        *
- * regarding copyright ownership.  The ASF licenses this file   *
- * to you under the Apache License, Version 2.0 (the            *
- * "License"); you may not use this file except in compliance   *
- * with the License.  You may obtain a copy of the License at   *
- *                                                              *
- *   http://www.apache.org/licenses/LICENSE-2.0                 *
- *                                                              *
- * Unless required by applicable law or agreed to in writing,   *
- * software distributed under the License is distributed on an  *
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY       *
- * KIND, either express or implied.  See the License for the    *
- * specific language governing permissions and limitations      *
- * under the License.                                           *
- ****************************************************************/
-package org.apache.james.protocols.api.handler;
-
-import java.nio.ByteBuffer;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
-
-import org.apache.james.protocols.api.ProtocolSession;
-import org.apache.james.protocols.api.ProtocolSession.State;
-import org.apache.james.protocols.api.Response;
-
-/**
- * A special {@link LineHandler} which will "buffer" the received lines till a point and the push them all at
- * one to the {@link #onLines(ProtocolSession, Collection)} method
- * 
- *
- * @param <S>
- */
-public abstract class MultiLineHandler<S extends ProtocolSession> implements LineHandler<S> {
-
-    private static final String BUFFERED_LINES = "BUFFERED_LINES";
-    
-    @Override
-    @SuppressWarnings("unchecked")
-    public Response onLine(S session, ByteBuffer line) {
-        Collection<ByteBuffer> lines = (List<ByteBuffer>) session.getAttachment(BUFFERED_LINES, State.Transaction);
-        if (lines == null)  {
-            lines = new ArrayList<>();
-            session.setAttachment(BUFFERED_LINES, lines, State.Transaction);
-        }
-        lines.add(line);
-        if (isReady(session, line)) {
-            return onLines(session, (Collection<ByteBuffer>) session.setAttachment(BUFFERED_LINES, null, State.Transaction));
-        }
-        return null;
-    }
-
-    /**
-     * Return <code>true</code> if the buffered lines are ready to get pushed to the {@link #onLines(ProtocolSession, Collection)} method
-     */
-    protected abstract boolean isReady(S session, ByteBuffer line);
-    
-    /**
-     * Handle the buffered lines
-     *
-     * @return response
-     */
-    protected abstract Response onLines(S session, Collection<ByteBuffer> lines);
-}


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org