You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by "Madhan Neethiraj (Jira)" <ji...@apache.org> on 2020/02/24 00:20:00 UTC

[jira] [Commented] (ATLAS-3560) Not checking for relationshipDefs attributes when defining entities

    [ https://issues.apache.org/jira/browse/ATLAS-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043100#comment-17043100 ] 

Madhan Neethiraj commented on ATLAS-3560:
-----------------------------------------

I suggest the following to resolve such name conflict: the attributes {{injected}} into entity-def/instance, due to references in relationship-def, should use qualifiedName of the relationship-end. With this, relationship {{avro_schema_associatedEntities}}  would inject attribute named {{avro_schema_associatedEntities.schema }}(instead of simply {{schema}}) in entity-def {{DataSet}}.

For backward compatibility, relationship-ends marked with {{isLegacyAttribute=true}} should continue to be injected with simple name. Here is an example showing both types of relationship attributes in an entity-def: 
{noformat}
  hive_table:
    relationship-attributes: [ db, columns, partitionKeys, sd, hive_table_ddl_queries.ddlQueries ]
                                |     |          |          |             |
                                +-----+------+---+----------+             |
                                             |                            |
              isLegacyAttribute=true <------ +                            +-----> isLegacyAttribute=false

{noformat}

> Not checking for relationshipDefs attributes when defining entities
> -------------------------------------------------------------------
>
>                 Key: ATLAS-3560
>                 URL: https://issues.apache.org/jira/browse/ATLAS-3560
>             Project: Atlas
>          Issue Type: Bug
>          Components: atlas-webui
>    Affects Versions: 1.0.0, 2.0.0, 2.1.0
>            Reporter: Logan Rickert
>            Assignee: chaitali borole
>            Priority: Major
>
> When creating an entity definition, it is possible to specify an attribute key that will later be overwritten/shadowed through relationshipDef. 
>  
> See [~madhan]'s comment for more information: https://issues.apache.org/jira/browse/ATLAS-2215?focusedCommentId=16995162&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16995162
>  
> Related: https://issues.apache.org/jira/browse/ATLAS-2763



--
This message was sent by Atlassian Jira
(v8.3.4#803005)