You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Samuel Yuan (JIRA)" <ji...@apache.org> on 2013/03/11 07:11:13 UTC

[jira] [Commented] (HIVE-4067) Followup to HIVE-701: reduce ambiguity in grammar

    [ https://issues.apache.org/jira/browse/HIVE-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598566#comment-13598566 ] 

Samuel Yuan commented on HIVE-4067:
-----------------------------------

This is referring to the Java code in the @members section. The section is still being properly inserted into the generated HiveParser.java file, which then compiles fine, so I don't know why ANTLR is complaining. I'll look into it.
                
> Followup to HIVE-701: reduce ambiguity in grammar
> -------------------------------------------------
>
>                 Key: HIVE-4067
>                 URL: https://issues.apache.org/jira/browse/HIVE-4067
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 0.11.0
>            Reporter: Samuel Yuan
>            Assignee: Samuel Yuan
>            Priority: Minor
>         Attachments: HIVE-4067.D8883.1.patch
>
>
> After HIVE-701 the grammar has become much more ambiguous, and the compilation generates a large number of warnings. Making FROM, DISTINCT, PRESERVE, COLUMN, ALL, AND, OR, and NOT reserved keywords again reduces the number of warnings to 134, up from the original 81 warnings but down from the 565 after HIVE-701. Most of the remaining ambiguity is trivial, an example being "KW_ELEM_TYPE | KW_KEY_TYPE | KW_VALUE_TYPE | identifier", and they are all correctly handled by ANTLR.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira