You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/10 22:53:40 UTC
[GitHub] [airflow] PApostol opened a new pull request #20210: Add some type hints for Hive providers
PApostol opened a new pull request #20210:
URL: https://github.com/apache/airflow/pull/20210
Some missing type hints from `airflow/providers/apache/hive/transfers/vertica_to_hive.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991690816
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991703054
> Woah, thanks @potiuk I wasn't aware! Does the hook automagically sort out the imports with `isort` upon merging to main or do I need to push a fix for the test to pass?
You need to push a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991691041
Oh. Static checks @PApostol : instaling pre-commit locally helps with that immensely (not sure if told you yet :) ) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20210:
URL: https://github.com/apache/airflow/pull/20210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] PApostol commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
PApostol commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991702615
Woah, thanks @potiuk I wasn't aware! Does the hook automagically sort out the imports with `isort` upon merging to main or do I need to push a fix for the test to pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991703054
> Woah, thanks @potiuk I wasn't aware! Does the hook automagically sort out the imports with `isort` upon merging to main or do I need to push a fix for the test to pass?
You need to push a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20210:
URL: https://github.com/apache/airflow/pull/20210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] PApostol commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
PApostol commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991702615
Woah, thanks @potiuk I wasn't aware! Does the hook automagically sort out the imports with `isort` upon merging to main or do I need to push a fix for the test to pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991736291
@PApostol @eladkal - but indeed it automagically fixes it for you locally :).
The best thing ever: I do not remember the last time I've added licence header. That's by far the bigest win ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991691041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20210: Add some type hints for Hive providers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20210:
URL: https://github.com/apache/airflow/pull/20210#issuecomment-991690816
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org