You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Steve Jiang (JIRA)" <ji...@apache.org> on 2010/02/17 02:36:28 UTC
[jira] Created: (TS-188) proxy.config.http.cache.required_headers
value 1 does not allow caching of items with only Cache-Control: max-age
proxy.config.http.cache.required_headers value 1 does not allow caching of items with only Cache-Control: max-age
-----------------------------------------------------------------------------------------------------------------
Key: TS-188
URL: https://issues.apache.org/jira/browse/TS-188
Project: Traffic Server
Issue Type: Bug
Components: Cache
Reporter: Steve Jiang
Assignee: Steve Jiang
Priority: Minor
Fix For: 2.0.0a
the records.config variable proxy.config.http.cache.required_headers has three options:
# 0 - No required headers to make document cachable
# 1 - at least "Last-Modified:" header required
# 2 - explicit lifetime required, "Expires:" or "Cache-Control:"
The options are ordered in least restrictive to most restrictive. However, choosing option 1 does not allow YTS to cache objects with CC: max-age, whereas option 2 allows it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-188) proxy.config.http.cache.required_headers
value 1 does not allow caching of items with only Cache-Control: max-age
Posted by "Steve Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Jiang updated TS-188:
---------------------------
Attachment: TS188_sjiang_2.diff
It turns out even option 2 is not requiring explicit max-age, only Cache-Control. So something like "Cache-Control: foo" would have allowed TS to cache a document with required_headers 2.
I'm attaching a fix to require Expires, CC: max-age, or CC: s-maxage.
> proxy.config.http.cache.required_headers value 1 does not allow caching of items with only Cache-Control: max-age
> -----------------------------------------------------------------------------------------------------------------
>
> Key: TS-188
> URL: https://issues.apache.org/jira/browse/TS-188
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Reporter: Steve Jiang
> Assignee: Steve Jiang
> Priority: Minor
> Fix For: 2.0.0a
>
> Attachments: files.htm.diff, http.htm.diff, TS188_sjiang.diff, TS188_sjiang_2.diff
>
>
> the records.config variable proxy.config.http.cache.required_headers has three options:
> # 0 - No required headers to make document cachable
> # 1 - at least "Last-Modified:" header required
> # 2 - explicit lifetime required, "Expires:" or "Cache-Control:"
> The options are ordered in least restrictive to most restrictive. However, choosing option 1 does not allow YTS to cache objects with CC: max-age, whereas option 2 allows it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-188) proxy.config.http.cache.required_headers
value 1 does not allow caching of items with only Cache-Control: max-age
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835575#action_12835575 ]
Leif Hedstrom commented on TS-188:
----------------------------------
+1 from me, it makes no sense that CC: foo would make something cacheable I think?
> proxy.config.http.cache.required_headers value 1 does not allow caching of items with only Cache-Control: max-age
> -----------------------------------------------------------------------------------------------------------------
>
> Key: TS-188
> URL: https://issues.apache.org/jira/browse/TS-188
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Reporter: Steve Jiang
> Assignee: Steve Jiang
> Priority: Minor
> Fix For: 2.0.0a
>
> Attachments: files.htm.diff, http.htm.diff, TS188_sjiang.diff, TS188_sjiang_2.diff
>
>
> the records.config variable proxy.config.http.cache.required_headers has three options:
> # 0 - No required headers to make document cachable
> # 1 - at least "Last-Modified:" header required
> # 2 - explicit lifetime required, "Expires:" or "Cache-Control:"
> The options are ordered in least restrictive to most restrictive. However, choosing option 1 does not allow YTS to cache objects with CC: max-age, whereas option 2 allows it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-188) proxy.config.http.cache.required_headers
value 1 does not allow caching of items with only Cache-Control: max-age
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834956#action_12834956 ]
Bryan Call commented on TS-188:
-------------------------------
reviewed: looks good
We should also update the comments in the records.config to state that CC: max-age is also acceptable.
> proxy.config.http.cache.required_headers value 1 does not allow caching of items with only Cache-Control: max-age
> -----------------------------------------------------------------------------------------------------------------
>
> Key: TS-188
> URL: https://issues.apache.org/jira/browse/TS-188
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Reporter: Steve Jiang
> Assignee: Steve Jiang
> Priority: Minor
> Fix For: 2.0.0a
>
> Attachments: TS188_sjiang.diff
>
>
> the records.config variable proxy.config.http.cache.required_headers has three options:
> # 0 - No required headers to make document cachable
> # 1 - at least "Last-Modified:" header required
> # 2 - explicit lifetime required, "Expires:" or "Cache-Control:"
> The options are ordered in least restrictive to most restrictive. However, choosing option 1 does not allow YTS to cache objects with CC: max-age, whereas option 2 allows it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-188) proxy.config.http.cache.required_headers
value 1 does not allow caching of items with only Cache-Control: max-age
Posted by "Miles Libbey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Miles Libbey updated TS-188:
----------------------------
Attachment: http.htm.diff
files.htm.diff
updates to docs as Bryan suggests
> proxy.config.http.cache.required_headers value 1 does not allow caching of items with only Cache-Control: max-age
> -----------------------------------------------------------------------------------------------------------------
>
> Key: TS-188
> URL: https://issues.apache.org/jira/browse/TS-188
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Reporter: Steve Jiang
> Assignee: Steve Jiang
> Priority: Minor
> Fix For: 2.0.0a
>
> Attachments: files.htm.diff, http.htm.diff, TS188_sjiang.diff
>
>
> the records.config variable proxy.config.http.cache.required_headers has three options:
> # 0 - No required headers to make document cachable
> # 1 - at least "Last-Modified:" header required
> # 2 - explicit lifetime required, "Expires:" or "Cache-Control:"
> The options are ordered in least restrictive to most restrictive. However, choosing option 1 does not allow YTS to cache objects with CC: max-age, whereas option 2 allows it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-188) proxy.config.http.cache.required_headers
value 1 does not allow caching of items with only Cache-Control: max-age
Posted by "Steve Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Jiang resolved TS-188.
----------------------------
Resolution: Fixed
> proxy.config.http.cache.required_headers value 1 does not allow caching of items with only Cache-Control: max-age
> -----------------------------------------------------------------------------------------------------------------
>
> Key: TS-188
> URL: https://issues.apache.org/jira/browse/TS-188
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Reporter: Steve Jiang
> Assignee: Steve Jiang
> Priority: Minor
> Fix For: 2.0.0a
>
> Attachments: files.htm.diff, http.htm.diff, TS188_sjiang.diff, TS188_sjiang_2.diff
>
>
> the records.config variable proxy.config.http.cache.required_headers has three options:
> # 0 - No required headers to make document cachable
> # 1 - at least "Last-Modified:" header required
> # 2 - explicit lifetime required, "Expires:" or "Cache-Control:"
> The options are ordered in least restrictive to most restrictive. However, choosing option 1 does not allow YTS to cache objects with CC: max-age, whereas option 2 allows it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-188) proxy.config.http.cache.required_headers
value 1 does not allow caching of items with only Cache-Control: max-age
Posted by "Steve Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Jiang updated TS-188:
---------------------------
Attachment: TS188_sjiang.diff
Patch to not bail if Cache-Control is present
> proxy.config.http.cache.required_headers value 1 does not allow caching of items with only Cache-Control: max-age
> -----------------------------------------------------------------------------------------------------------------
>
> Key: TS-188
> URL: https://issues.apache.org/jira/browse/TS-188
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache
> Reporter: Steve Jiang
> Assignee: Steve Jiang
> Priority: Minor
> Fix For: 2.0.0a
>
> Attachments: TS188_sjiang.diff
>
>
> the records.config variable proxy.config.http.cache.required_headers has three options:
> # 0 - No required headers to make document cachable
> # 1 - at least "Last-Modified:" header required
> # 2 - explicit lifetime required, "Expires:" or "Cache-Control:"
> The options are ordered in least restrictive to most restrictive. However, choosing option 1 does not allow YTS to cache objects with CC: max-age, whereas option 2 allows it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.