You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/05/27 21:05:32 UTC
Review Request 34728: Changed callbacks to take copies rather than
references in monitor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34728/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
Changed callbacks to take copies rather than references in monitor.
Diffs
-----
src/slave/monitor.cpp 12d478dd6086b32685217fdd854ffd2e05067ac4
Diff: https://reviews.apache.org/r/34728/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 34728: Changed callbacks to take copies rather than
references in monitor.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34728/#review85426
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On May 27, 2015, 12:43 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34728/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 12:43 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2771
> https://issues.apache.org/jira/browse/MESOS-2771
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed callbacks to take copies rather than references in monitor.
>
>
> Diffs
> -----
>
> src/slave/monitor.cpp 12d478dd6086b32685217fdd854ffd2e05067ac4
>
> Diff: https://reviews.apache.org/r/34728/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 34728: Changed callbacks to take copies rather than
references in monitor.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34728/
-----------------------------------------------------------
(Updated May 27, 2015, 12:43 p.m.)
Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
Bugs: MESOS-2771
https://issues.apache.org/jira/browse/MESOS-2771
Repository: mesos
Description
-------
Changed callbacks to take copies rather than references in monitor.
Diffs
-----
src/slave/monitor.cpp 12d478dd6086b32685217fdd854ffd2e05067ac4
Diff: https://reviews.apache.org/r/34728/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen