You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/11 23:00:37 UTC

[GitHub] [flink] Cyberness commented on pull request #20257: [FLINK-24943][Connectors / Kinesis] Explicitly create KryoSerializer for SequenceNumber class in Kinesis Consumer

Cyberness commented on PR #20257:
URL: https://github.com/apache/flink/pull/20257#issuecomment-1275379856

   > The code changes look good. Recognise that we specify a KryoSerializer instead of making the SequenceNumber a POJO to maintain backwards compatibility. Given that we are changing the state serializer, could we do a sanity test to check the following?
   > 
   > * we can disableGenericTypes (as reported [here](https://issues.apache.org/jira/browse/FLINK-24549))
   > * a snapshot created from old consumer is valid for a new consumer
   
   Yes, I can work on it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org