You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2010/03/03 05:50:09 UTC
svn commit: r918325 -
/hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java
Author: stack
Date: Wed Mar 3 04:50:08 2010
New Revision: 918325
URL: http://svn.apache.org/viewvc?rev=918325&view=rev
Log:
HBASE-2244 META gets inconsistent in a number of crash scenarios
Modified:
hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java
Modified: hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java?rev=918325&r1=918324&r2=918325&view=diff
==============================================================================
--- hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java (original)
+++ hadoop/hbase/trunk/core/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java Wed Mar 3 04:50:08 2010
@@ -342,9 +342,8 @@
if (!references) return references;
if (!verifyDaughterRowPresent(rowContent, qualifier, srvr, metaRegionName,
hri, parent)) {
- // If we got here, we added a daughter region to metatable. Update
- // parent row that daughter has been verified present so we don't check
- // for it by doing a get each time through here.
+ // If we got here, then the parent row does not yet have the
+ // "daughter row verified present" marker present. Add it.
addDaughterRowChecked(metaRegionName, srvr, parent.getRegionName(), hri,
qualifier);
}
@@ -360,8 +359,8 @@
* @param metaRegionName
* @param daughterHRI
* @throws IOException
- * @return True, if the daughter row is present in meta. If false, this
- * method just added it to meta.
+ * @return True, if parent row has marker for "daughter row verified present"
+ * else, false (and will do fixup adding daughter if daughter not present).
*/
private boolean verifyDaughterRowPresent(final Result rowContent,
final byte [] daughter, final HRegionInterface srvr,