You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by jb...@apache.org on 2012/05/09 10:07:35 UTC

svn commit: r1335968 - /karaf/cellar/trunk/shell/src/main/java/org/apache/karaf/cellar/shell/NodePingCommand.java

Author: jbonofre
Date: Wed May  9 08:07:35 2012
New Revision: 1335968

URL: http://svn.apache.org/viewvc?rev=1335968&view=rev
Log:
Improve cluster:node-ping output

Modified:
    karaf/cellar/trunk/shell/src/main/java/org/apache/karaf/cellar/shell/NodePingCommand.java

Modified: karaf/cellar/trunk/shell/src/main/java/org/apache/karaf/cellar/shell/NodePingCommand.java
URL: http://svn.apache.org/viewvc/karaf/cellar/trunk/shell/src/main/java/org/apache/karaf/cellar/shell/NodePingCommand.java?rev=1335968&r1=1335967&r2=1335968&view=diff
==============================================================================
--- karaf/cellar/trunk/shell/src/main/java/org/apache/karaf/cellar/shell/NodePingCommand.java (original)
+++ karaf/cellar/trunk/shell/src/main/java/org/apache/karaf/cellar/shell/NodePingCommand.java Wed May  9 08:07:35 2012
@@ -39,10 +39,11 @@ public class NodePingCommand extends Clu
     protected Object doExecute() throws Exception {
         Node node = clusterManager.findNodeById(nodeId);
         if (node == null) {
-            System.out.println("Node " + nodeId + " is not found");
+            System.out.println("Cluster node " + nodeId + " doesn't exist");
             return null;
         }
-        System.out.println("Pinging node: " + node.getId());
+
+        System.out.println("PING " + node.getId());
         for (int i = 1; i <= iterations; i++) {
             Long start = System.currentTimeMillis();
             Ping ping = new Ping(clusterManager.generateId());
@@ -50,10 +51,10 @@ public class NodePingCommand extends Clu
             executionContext.execute(ping);
             Long stop = System.currentTimeMillis();
             Long delay = stop - start;
-            if (delay > TIMEOUT) {
-                System.err.println(String.format("TIMEOUT %s %s %sms", i, node.getId(), delay));
+            if (delay >= TIMEOUT) {
+                System.err.println(String.format("TIMEOUT %s %s", i, node.getId()));
             } else {
-                System.out.println(String.format("PING %s %s %sms", i, node.getId(), delay));
+                System.out.println(String.format("from %s: req=%s time=%s ms", i, node.getId(), delay));
             }
             Thread.sleep(interval);
         }