You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by ca...@apache.org on 2009/10/11 05:06:44 UTC

svn commit: r824004 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/PatternLayout.java

Author: carnold
Date: Sun Oct 11 03:06:43 2009
New Revision: 824004

URL: http://svn.apache.org/viewvc?rev=824004&view=rev
Log:
Bug 47350: Add recommendation for EnhancedPatternLayout due to synchronization issues in PatternLayout

Modified:
    logging/log4j/trunk/src/changes/changes.xml
    logging/log4j/trunk/src/main/java/org/apache/log4j/PatternLayout.java

Modified: logging/log4j/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=824004&r1=824003&r2=824004&view=diff
==============================================================================
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Sun Oct 11 03:06:43 2009
@@ -87,7 +87,8 @@
        <action action="add" issue="46983">More Debug output for log4j auto-configure requested.</action>
        <action action="add" issue="47107">Add MDC.clear().</action>
        <action action="fix" issue="47547">NullPointerException when calling Category.removeAllAppenders().</action>
-       <action action="add" issue-"28647">Allow overridding of flush strategy.</action>
+       <action action="add" issue-"28647">Allow overriding of flush strategy.</action>
+       <action action="fix" issue="47350">Add recommendation to use EnhancedPatternLayout to avoid synchronization issues in PatternLayout</action>
     </release>
 
   

Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/PatternLayout.java
URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/PatternLayout.java?rev=824004&r1=824003&r2=824004&view=diff
==============================================================================
--- logging/log4j/trunk/src/main/java/org/apache/log4j/PatternLayout.java (original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/PatternLayout.java Sun Oct 11 03:06:43 2009
@@ -29,6 +29,11 @@
 /**
 
    A flexible layout configurable with pattern string.
+   
+   This code is known to have synchronization and other issues
+   which are not present in org.apache.log4j.EnhancedPatternLayout.
+   EnhancedPatternLayout should be used in preference to PatternLayout.
+   EnhancedPatternLayout is distributed in the log4j extras companion.
 
    <p>The goal of this class is to {@link #format format} a {@link
    LoggingEvent} and return the results as a String. The results



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org