You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2016/10/31 17:48:46 UTC
[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4890
Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
......................................................................
Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
ASAN detected a heap-buffer-overflow with these changes.
This reverts commit 9f3f4b713d78e8dcf02c02def447195a04f408e6.
Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
---
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-scanner.h
M fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java
M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
M fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
5 files changed, 202 insertions(+), 67 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/4890/1
--
To view, visit http://gerrit.cloudera.org:8080/4890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
......................................................................
Patch Set 1: Code-Review-2
I think I've figured out the problem, and it's easy enough to fix. Preventing this change from being merged for now.
--
To view, visit http://gerrit.cloudera.org:8080/4890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
......................................................................
Patch Set 1:
No, and it will be some time until I can dig deeper.
--
To view, visit http://gerrit.cloudera.org:8080/4890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
......................................................................
Patch Set 1:
Any idea how hard the fix is?
--
To view, visit http://gerrit.cloudera.org:8080/4890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has abandoned this change.
Change subject: Revert "IMPALA-3346: DeepCopy() Kudu rows into Impala tuples."
......................................................................
Abandoned
Proper fix being merged now.
--
To view, visit http://gerrit.cloudera.org:8080/4890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I53def9e1c213682fc737d76989a60b0b5e813032
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>