You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HeartSaVioR (via GitHub)" <gi...@apache.org> on 2023/05/02 00:43:14 UTC
[GitHub] [spark] HeartSaVioR commented on a diff in pull request #41001: [SPARK-43328][SS] Add latest timestamp on no-execution trigger for Idle event in streaming query listener
HeartSaVioR commented on code in PR #41001:
URL: https://github.com/apache/spark/pull/41001#discussion_r1181993402
##########
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListener.scala:
##########
@@ -140,7 +140,8 @@ object StreamingQueryListener {
@Evolving
class QueryIdleEvent private[sql](
val id: UUID,
- val runId: UUID) extends Event
+ val runId: UUID,
+ val timestamp: String) extends Event
Review Comment:
I'll bring the parameters in the classdoc for the same of python side. Thanks for the input!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org