You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/02/09 17:23:51 UTC

[GitHub] [commons-csv] ameyjadiye commented on a change in pull request #56: Replace findbugs with spotbugs

ameyjadiye commented on a change in pull request #56: Replace findbugs with spotbugs
URL: https://github.com/apache/commons-csv/pull/56#discussion_r376800103
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -208,6 +208,14 @@
           <suppressionsLocation>${basedir}/src/main/resources/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
+        <version>${commons.spotbugs.version}</version>
+        <configuration>
+          <excludeFilterFile>${basedir}/src/main/resources/spotbugs/spotbugs-exclude-filter.xml</excludeFilterFile>
 
 Review comment:
   Thanks for the suggestions @garydgregory and @aherbert, I have pushed correct changes now.
   let me keep this PR for just replacing findbugs with spotbugs. I will correct other configs with other PR if this goes correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services