You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2018/05/13 21:28:48 UTC
[GitHub] spark pull request #21315: [SPARK-23780][R] Failed to use googleVis library ...
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/21315
[SPARK-23780][R] Failed to use googleVis library with new SparkR
## What changes were proposed in this pull request?
change generic to get it to work with googleVis
also fix lintr
## How was this patch tested?
manual test, unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felixcheung/spark googvis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21315
----
commit 739ca64fdf730c1328d0b33dab07d0df02424791
Author: Felix Cheung <fe...@...>
Date: 2018-05-13T21:24:05Z
change generic to work with other toJSON
fix lintr
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3180/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21315
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21315: [SPARK-23780][R] Failed to use googleVis library ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21315
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21315
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90559/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21315
**[Test build #90559 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90559/testReport)** for PR 21315 at commit [`739ca64`](https://github.com/apache/spark/commit/739ca64fdf730c1328d0b33dab07d0df02424791).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21315
merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/21315
LGTM. Lets wait till #21314 is merged ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21315
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21315
the main change is https://github.com/apache/spark/compare/master...felixcheung:googvis?expand=1#diff-8e3d61ff66c9ffcd6ffb7a8eedc08409
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21315
**[Test build #90559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90559/testReport)** for PR 21315 at commit [`739ca64`](https://github.com/apache/spark/commit/739ca64fdf730c1328d0b33dab07d0df02424791).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21315: [SPARK-23780][R] Failed to use googleVis library with ne...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21315
@shivaram
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org